chrome/browser/metrics/metrics_service.cc - Issue 7324017: Split SystemAccess into TimezoneSettings, StatisticsProvider, and SyslogsProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 7324017: Split SystemAccess into TimezoneSettings, StatisticsProvider, and SyslogsProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comments Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_info_private_api_chromeos.cc ('k') | chrome/browser/policy/device_management_backend_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/metrics_service.cc

diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc

index 4448c41f589ef67535288c97c23ba83ba4ff4d86..73c652c06afd51da7f3be13b346cfc5191bd5050 100644

--- a/chrome/browser/metrics/metrics_service.cc

+++ b/chrome/browser/metrics/metrics_service.cc

@@ -200,7 +200,7 @@

#if defined(OS_CHROMEOS)

#include "chrome/browser/chromeos/cros/cros_library.h"

#include "chrome/browser/chromeos/external_metrics.h"

-#include "chrome/browser/chromeos/system_access.h"

+#include "chrome/browser/chromeos/system/statistics_provider.h"

#endif

namespace {

@@ -343,7 +343,7 @@ class MetricsService::InitTask : public Task {

webkit::npapi::PluginList::Singleton()->GetPlugins(false, &plugins);

std::string hardware_class; // Empty string by default.

#if defined(OS_CHROMEOS)

- chromeos::SystemAccess::GetInstance()->GetMachineStatistic(

+ chromeos::system::StatisticsProvider::GetInstance()->GetMachineStatistic(

"hardware_class", &hardware_class);

#endif // OS_CHROMEOS

callback_loop_->PostTask(FROM_HERE, new InitTaskComplete(