Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: chrome/browser/chromeos/name_value_pairs_parser.cc

Issue 7324017: Split SystemAccess into TimezoneSettings, StatisticsProvider, and SyslogsProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/name_value_pairs_parser.cc
diff --git a/chrome/browser/chromeos/name_value_pairs_parser.cc b/chrome/browser/chromeos/name_value_pairs_parser.cc
deleted file mode 100644
index be38daffd5b1a50bb8f547e726cf4afa386a9ba0..0000000000000000000000000000000000000000
--- a/chrome/browser/chromeos/name_value_pairs_parser.cc
+++ /dev/null
@@ -1,103 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/chromeos/name_value_pairs_parser.h"
-
-#include "base/command_line.h"
-#include "base/logging.h"
-#include "base/process_util.h"
-#include "base/string_tokenizer.h"
-#include "base/string_util.h"
-#include "base/threading/thread_restrictions.h"
-
-namespace chromeos { // NOLINT
-
-namespace {
-
-const char kQuoteChars[] = "\"";
-
-} // namespace
-
-NameValuePairsParser::NameValuePairsParser(NameValueMap* map)
- : map_(map) {
-}
-
-void NameValuePairsParser::AddNameValuePair(const std::string& key,
- const std::string& value) {
- (*map_)[key] = value;
- VLOG(1) << "name: " << key << ", value: " << value;
-}
-
-bool NameValuePairsParser::ParseNameValuePairs(const std::string& in_string,
- const std::string& eq,
- const std::string& delim) {
- // Set up the pair tokenizer.
- StringTokenizer pair_toks(in_string, delim);
- pair_toks.set_quote_chars(kQuoteChars);
- // Process token pairs.
- while (pair_toks.GetNext()) {
- std::string pair(pair_toks.token());
- if (pair.find(eq) == 0) {
- LOG(WARNING) << "Empty key: '" << pair << "'. Aborting.";
- return false;
- }
- StringTokenizer keyvalue(pair, eq);
- std::string key,value;
- if (keyvalue.GetNext()) {
- TrimString(keyvalue.token(), kQuoteChars, &key);
- if (keyvalue.GetNext()) {
- TrimString(keyvalue.token(), kQuoteChars, &value);
- if (keyvalue.GetNext()) {
- LOG(WARNING) << "Multiple key tokens: '" << pair << "'. Aborting.";
- return false;
- }
- }
- }
- if (key.empty()) {
- LOG(WARNING) << "Invalid token pair: '" << pair << "'. Aborting.";
- return false;
- }
- AddNameValuePair(key, value);
- }
- return true;
-}
-
-bool NameValuePairsParser::GetSingleValueFromTool(int argc,
- const char* argv[],
- const std::string& key) {
- CommandLine command_line(argc, argv);
- std::string output_string;
- // TODO(stevenjb,satorux): Make this non blocking: crosbug.com/5603.
- base::ThreadRestrictions::ScopedAllowIO allow_io_for_thread_join;
- if (argc < 1 || !base::GetAppOutput(command_line, &output_string)) {
- LOG(WARNING) << "Error excuting: " << command_line.command_line_string();
- return false;
- }
- TrimWhitespaceASCII(output_string, TRIM_ALL, &output_string);
- AddNameValuePair(key, output_string);
- return true;
-}
-
-bool NameValuePairsParser::ParseNameValuePairsFromTool(
- int argc,
- const char* argv[],
- const std::string& eq,
- const std::string& delim) {
- CommandLine command_line(argc, argv);
- std::string output_string;
- // TODO(stevenjb,satorux): Make this non blocking: crosbug.com/5603.
- base::ThreadRestrictions::ScopedAllowIO allow_io_for_thread_join;
- if (argc < 1 || !base::GetAppOutput(command_line, &output_string)) {
- LOG(WARNING) << "Error excuting: " << command_line.command_line_string();
- return false;
- }
- if (!ParseNameValuePairs(output_string, eq, delim)) {
- LOG(WARNING) << "Error parsing values while excuting: "
- << command_line.command_line_string();
- return false;
- }
- return true;
-}
-
-} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/name_value_pairs_parser.h ('k') | chrome/browser/chromeos/name_value_pairs_parser_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698