Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 7310016: GTK: Now that we depend on gtk 2.18+, replace this pattern: (Closed)

Created:
9 years, 5 months ago by Elliot Glaysher
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

GTK: Now that we depend on gtk 2.18+, replace this pattern: if (visible) gtk_widget_show(...); else gtk_widget_hide(...); with: gtk_widget_set_visible(..., visible); BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -55 lines) Patch
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 3 chunks +13 lines, -25 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/profile_menu_button.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_gtk.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
9 years, 5 months ago (2011-07-06 22:29:13 UTC) #1
Evan Martin
awesome, LGTM
9 years, 5 months ago (2011-07-06 22:45:35 UTC) #2
commit-bot: I haz the power
9 years, 5 months ago (2011-07-07 18:28:37 UTC) #3
Change committed as 91729

Powered by Google App Engine
This is Rietveld 408576698