chrome/browser/ui/gtk/browser_toolbar_gtk.cc - Issue 7310016: GTK: Now that we depend on gtk 2.18+, replace this pattern:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/browser_toolbar_gtk.cc

Issue 7310016: GTK: Now that we depend on gtk 2.18+, replace this pattern: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/browser_toolbar_gtk.cc

diff --git a/chrome/browser/ui/gtk/browser_toolbar_gtk.cc b/chrome/browser/ui/gtk/browser_toolbar_gtk.cc

index 06238dd033803bfd6c305cc93c746fd749b2c5ee..71fadf1d1e2306b5593033e6e153b294e986923c 100644

--- a/chrome/browser/ui/gtk/browser_toolbar_gtk.cc

+++ b/chrome/browser/ui/gtk/browser_toolbar_gtk.cc

@@ -615,11 +615,8 @@ void BrowserToolbarGtk::OnDragDataReceived(GtkWidget* widget,

void BrowserToolbarGtk::NotifyPrefChanged(const std::string* pref) {

if (!pref || *pref == prefs::kShowHomeButton) {

- if (show_home_button_.GetValue() && !ShouldOnlyShowLocation()) {

- gtk_widget_show(home_->widget());

- } else {

- gtk_widget_hide(home_->widget());

- }

+ bool visible = show_home_button_.GetValue() && !ShouldOnlyShowLocation();

+ gtk_widget_set_visible(home_->widget(), visible);

}

if (!pref ||