Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Unified Diff: chrome/browser/ui/gtk/location_bar_view_gtk.cc

Issue 7310016: GTK: Now that we depend on gtk 2.18+, replace this pattern: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/browser_toolbar_gtk.cc ('k') | chrome/browser/ui/gtk/profile_menu_button.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/location_bar_view_gtk.cc
diff --git a/chrome/browser/ui/gtk/location_bar_view_gtk.cc b/chrome/browser/ui/gtk/location_bar_view_gtk.cc
index 4fe87367e941808183ae026f9b46b51baa3f22ea..4047e232498cd9f901e788b80a3b0d54746b6a4b 100644
--- a/chrome/browser/ui/gtk/location_bar_view_gtk.cc
+++ b/chrome/browser/ui/gtk/location_bar_view_gtk.cc
@@ -635,10 +635,7 @@ void LocationBarViewGtk::UpdateContentSettingsIcons() {
// If there are no visible content things, hide the top level box so it
// doesn't mess with padding.
- if (any_visible)
- gtk_widget_show(content_setting_hbox_.get());
- else
- gtk_widget_hide(content_setting_hbox_.get());
+ gtk_widget_set_visible(content_setting_hbox_.get(), any_visible);
}
void LocationBarViewGtk::UpdatePageActions() {
@@ -682,10 +679,8 @@ void LocationBarViewGtk::UpdatePageActions() {
// If there are no visible page actions, hide the hbox too, so that it does
// not affect the padding in the location bar.
- if (PageActionVisibleCount() && !ShouldOnlyShowLocation())
- gtk_widget_show(page_action_hbox_.get());
- else
- gtk_widget_hide(page_action_hbox_.get());
+ gtk_widget_set_visible(page_action_hbox_.get(),
+ PageActionVisibleCount() && !ShouldOnlyShowLocation());
}
void LocationBarViewGtk::InvalidatePageActions() {
« no previous file with comments | « chrome/browser/ui/gtk/browser_toolbar_gtk.cc ('k') | chrome/browser/ui/gtk/profile_menu_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698