Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 7251002: Remove files without an extension from the presubmit checks. (Closed)

Created:
9 years, 6 months ago by M-A Ruel
Modified:
9 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Remove files without an extension from the presubmit checks. This may include Makefile but it's saner to not include it by default R=dpranke@chromium.org BUG= TEST=updated Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90403

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M presubmit_support.py View 1 chunk +4 lines, -3 lines 2 comments Download
M tests/presubmit_unittest.py View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
9 years, 6 months ago (2011-06-24 18:04:53 UTC) #1
Dirk Pranke
LGTM. http://codereview.chromium.org/7251002/diff/1/presubmit_support.py File presubmit_support.py (right): http://codereview.chromium.org/7251002/diff/1/presubmit_support.py#newcode192 presubmit_support.py:192: # Note that ALL CAPS files are black ...
9 years, 6 months ago (2011-06-24 18:58:34 UTC) #2
M-A Ruel
9 years, 6 months ago (2011-06-24 19:11:36 UTC) #3
http://codereview.chromium.org/7251002/diff/1/presubmit_support.py
File presubmit_support.py (right):

http://codereview.chromium.org/7251002/diff/1/presubmit_support.py#newcode192
presubmit_support.py:192: # Note that ALL CAPS files are black listed in
DEFAULT_BLACK_LIST below.
On 2011/06/24 18:58:34, Dirk Pranke wrote:
> Aside ... I wonder if we should change this to just be a list of strings to
> match on extensions, and transform them into regexps internally. It might be
> less flexible, but it would also be clearer and less error-prone.

Make sense but some of them wouldn't work so it would be a mix of raw regex and
list of extensions. I'll do that when I'm bored. :)

Powered by Google App Engine
This is Rietveld 408576698