Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: presubmit_support.py

Issue 7251002: Remove files without an extension from the presubmit checks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_support.py
diff --git a/presubmit_support.py b/presubmit_support.py
index e1fcd3d086c209c1172f207f2ed3dc484b2f4c92..a292bd78d42884a6aad1afb5a0407d8f3471830f 100755
--- a/presubmit_support.py
+++ b/presubmit_support.py
@@ -186,15 +186,16 @@ class InputApi(object):
# File extensions that are considered source files from a style guide
# perspective. Don't modify this list from a presubmit script!
+ #
+ # Files without an extension aren't included in the list. If you want to
+ # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
+ # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
Dirk Pranke 2011/06/24 18:58:34 Aside ... I wonder if we should change this to jus
M-A Ruel 2011/06/24 19:11:36 Make sense but some of them wouldn't work so it wo
DEFAULT_WHITE_LIST = (
# C++ and friends
r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
# Scripts
r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
- # No extension at all, note that ALL CAPS files are black listed in
- # DEFAULT_BLACK_LIST below.
- r"(^|.*?[\\\/])[^.]+$",
# Other
r".+\.java$", r".+\.mk$", r".+\.am$",
)
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698