Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: tests/presubmit_unittest.py

Issue 7251002: Remove files without an extension from the presubmit checks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« presubmit_support.py ('K') | « presubmit_support.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/presubmit_unittest.py
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index 9ef2675b05829c9c4c322a819fb8c88ae4818d57..7f87be4181e2145cc41012a2c578b741d1fc6329 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -945,7 +945,6 @@ class InputApiUnittest(PresubmitTestsBase):
],
[
# Expected.
- 'a/experimental',
'a/experimental.cc',
'a/experimental.S',
],
@@ -960,7 +959,6 @@ class InputApiUnittest(PresubmitTestsBase):
],
[
# Expected.
- 'a/third_party',
'a/third_party.cc',
],
),
@@ -970,11 +968,13 @@ class InputApiUnittest(PresubmitTestsBase):
f('a/LOL_FILE/b'),
f('b.c/LOL_FILE'),
f('a/PRESUBMIT.py'),
+ f('a/FOO.json'),
+ f('a/FOO.java'),
],
[
# Expected.
- 'a/LOL_FILE/b',
'a/PRESUBMIT.py',
+ 'a/FOO.java',
],
),
(
@@ -995,7 +995,7 @@ class InputApiUnittest(PresubmitTestsBase):
False, None, False)
self.mox.ReplayAll()
- self.assertEqual(len(input_api.DEFAULT_WHITE_LIST), 22)
+ self.assertEqual(len(input_api.DEFAULT_WHITE_LIST), 21)
self.assertEqual(len(input_api.DEFAULT_BLACK_LIST), 9)
for item in files:
results = filter(input_api.FilterSourceFile, item[0])
« presubmit_support.py ('K') | « presubmit_support.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698