Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5504)

Unified Diff: chrome/browser/ui/panels/panel_manager.h

Issue 7242017: Support minimizing the panel into 3-pixel line on Windows. Also support bringing up/down the titl... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_manager.h
===================================================================
--- chrome/browser/ui/panels/panel_manager.h (revision 90291)
+++ chrome/browser/ui/panels/panel_manager.h (working copy)
@@ -21,8 +21,21 @@
// Returns a single instance.
static PanelManager* GetInstance();
- ~PanelManager();
+ virtual ~PanelManager();
+ // Removes the given panel. Both active and pending panel lists are checked.
+ // If an active panel is removed, pending panels could put on display if we
jennb 2011/06/27 23:18:02 Fix grammar in "pending planels could put on displ
jianli 2011/06/29 01:28:12 Could you suggest what need to change?
jennb 2011/06/29 21:10:09 ..., pending panels will be displayed if space all
+ // have spaces.
+ virtual void Remove(Panel* panel);
+
+ // Minimizes the given panel to full extent, that is, we only show 3-pixel
+ // lines.
+ virtual void Minimize(Panel* panel);
+
+ // Restores the given panel. If |titlebar_only| is true, we restore the panel
+ // to show the title bar only. Otherwise, we restore the panel fully.
+ virtual void Restore(Panel* panel, bool titlebar_only);
+
// Called when the display is changed, i.e. work area is updated.
void OnDisplayChanged();
@@ -30,11 +43,6 @@
// later.
Panel* CreatePanel(Browser* browser);
- // Removes the given panel. Both active and pending panel lists are checked.
- // If an active panel is removed, pending panels could put on display if we
- // have spaces.
- void Remove(Panel* panel);
-
// Minimizes all panels. This only applies to active panels since only them
// are visible.
void MinimizeAll();
@@ -54,7 +62,9 @@
// Returns the number of active panels.
int active_count() const { return active_panels_.size(); }
- private:
+ protected:
dcheng 2011/06/24 08:13:18 I think the C++ guide prefers that data members be
jianli 2011/06/29 01:28:12 Not needed. Reverted.
+ static PanelManager* Create();
+
typedef std::vector<Panel*> ActivePanels;
typedef std::deque<Panel*> PendingPanels;
@@ -116,6 +126,7 @@
// to when the dragging ends.
gfx::Rect dragging_panel_bounds_;
+ private:
DISALLOW_COPY_AND_ASSIGN(PanelManager);
};

Powered by Google App Engine
This is Rietveld 408576698