Support minimizing the panel into 3-pixel line on Windows. Also support bringing up/down the titl...

chrome/browser/ui/panels/panel_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_MANAGER_H_
 #define CHROME_BROWSER_UI_PANELS_PANEL_MANAGER_H_
 #pragma once
 
 #include <deque>
 #include <vector>
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "ui/gfx/rect.h"
 
 class Browser;
 class Panel;
 
 // This class manages a set of panels.
 class PanelManager {
  public:
   // Returns a single instance.
   static PanelManager* GetInstance();
 
-  ~PanelManager();
+  virtual ~PanelManager();
+
+  // Removes the given panel. Both active and pending panel lists are checked.
+  // If an active panel is removed, pending panels could put on display if we

[jennb, 2011/06/27 23:18:02]

Fix grammar in "pending planels could put on display if we have spaces".

[jianli, 2011/06/29 01:28:12]

Could you suggest what need to change?

[jennb, 2011/06/29 21:10:09]

..., pending panels will be displayed if space allows.

+  // have spaces.
+  virtual void Remove(Panel* panel);
+
+  // Minimizes the given panel to full extent, that is, we only show 3-pixel
+  // lines.
+  virtual void Minimize(Panel* panel);
+
+  // Restores the given panel. If |titlebar_only| is true, we restore the panel
+  // to show the title bar only. Otherwise, we restore the panel fully.
+  virtual void Restore(Panel* panel, bool titlebar_only);
 
   // Called when the display is changed, i.e. work area is updated.
   void OnDisplayChanged();
 
   // Creates a panel and returns it. The panel might be queued for display
   // later.
   Panel* CreatePanel(Browser* browser);
 
-  // Removes the given panel. Both active and pending panel lists are checked.
-  // If an active panel is removed, pending panels could put on display if we
-  // have spaces.
-  void Remove(Panel* panel);
-
   // Minimizes all panels. This only applies to active panels since only them
   // are visible.
   void MinimizeAll();
 
   // Restores all panels. This only applies to active panels since only them
   // are visible.
   void RestoreAll();
 
   // Removes all active panels. Pending panels will be processed for display.
   void RemoveAllActive();
 
   // Drags the given active panel.
   void StartDragging(Panel* panel);
   void Drag(int delta_x);
   void EndDragging(bool cancelled);
 
   // Returns the number of active panels.
   int active_count() const { return active_panels_.size(); }
 
- private:
+ protected:

[dcheng, 2011/06/24 08:13:18]

I think the C++ guide prefers that data members be private. Can we just add a
protected accessor for the active panels?

[jianli, 2011/06/29 01:28:12]

Not needed. Reverted.

+  static PanelManager* Create();
+
   typedef std::vector<Panel*> ActivePanels;
   typedef std::deque<Panel*> PendingPanels;
 
   PanelManager();
 
   // Handles all the panels that're delayed to be removed.
   void DelayedRemove();
 
   // Does the remove. Called from Remove and DelayedRemove.
   void DoRemove(Panel* panel);
@@ skipping 41 matching lines @@
 
   // Original x coordinate of the panel to drag. This is used to get back to
   // the original position when we cancel the dragging.
   int dragging_panel_original_x_;
 
   // Bounds of the panel to drag. It is first set to the original bounds when
   // the dragging happens. Then it is updated to the position that will be set
   // to when the dragging ends.
   gfx::Rect dragging_panel_bounds_;
 
+ private:
   DISALLOW_COPY_AND_ASSIGN(PanelManager);
 };
 
 #endif  // CHROME_BROWSER_UI_PANELS_PANEL_MANAGER_H_