Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3032)

Unified Diff: chrome/browser/ui/panels/panel_browser_view_browsertest.cc

Issue 7242017: Support minimizing the panel into 3-pixel line on Windows. Also support bringing up/down the titl... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browser_view_browsertest.cc
===================================================================
--- chrome/browser/ui/panels/panel_browser_view_browsertest.cc (revision 90291)
+++ chrome/browser/ui/panels/panel_browser_view_browsertest.cc (working copy)
@@ -251,6 +251,47 @@
browser_view->panel()->Close();
}
+
+ void TestMinimizeAndRestore() {
jennb 2011/06/27 23:18:02 Could you add a comment at the top of this class e
jianli 2011/06/29 01:28:12 Done.
+ PanelBrowserView* browser_view = CreatePanelBrowserView("PanelTest");
+ Panel* panel = browser_view->panel_.get();
+
+ EXPECT_EQ(PanelBrowserView::FULLY_RESTORED, browser_view->expand_state());
+ int initial_height = panel->GetBounds().height();
+ int titlebar_height =
+ browser_view->GetFrameView()->NonClientTopBorderHeight();
+
+ browser_view->MinimizePanel();
+ EXPECT_EQ(PanelBrowserView::FULLY_MINIMIZED, browser_view->expand_state());
+ EXPECT_LT(panel->GetBounds().height(), titlebar_height);
+ EXPECT_GT(panel->GetBounds().height(), 0);
+
+ browser_view->RestorePanel(true);
+ EXPECT_EQ(PanelBrowserView::TITLEBAR_RESTORED,
+ browser_view->expand_state());
+ EXPECT_EQ(titlebar_height, panel->GetBounds().height());
+
+ browser_view->MinimizePanel();
+ EXPECT_EQ(PanelBrowserView::FULLY_MINIMIZED, browser_view->expand_state());
+ EXPECT_LT(panel->GetBounds().height(), titlebar_height);
+ EXPECT_GT(panel->GetBounds().height(), 0);
+
+ browser_view->RestorePanel(true);
+ EXPECT_EQ(PanelBrowserView::TITLEBAR_RESTORED,
+ browser_view->expand_state());
+ EXPECT_EQ(titlebar_height, panel->GetBounds().height());
+
+ browser_view->RestorePanel(false);
+ EXPECT_EQ(PanelBrowserView::FULLY_RESTORED, browser_view->expand_state());
+ EXPECT_EQ(initial_height, panel->GetBounds().height());
+
+ // No-op if we try to "restore" from full height to titlebar height.
+ browser_view->RestorePanel(true);
+ EXPECT_EQ(PanelBrowserView::FULLY_RESTORED, browser_view->expand_state());
+ EXPECT_EQ(initial_height, panel->GetBounds().height());
+
+ browser_view->panel()->Close();
+ }
};
// Panel is not supported for Linux view yet.
@@ -549,4 +590,8 @@
FILE_PATH_LITERAL("extension2"), Extension::INVALID,
"http://home", "options.html");
}
+
+IN_PROC_BROWSER_TEST_F(PanelBrowserViewTest, MinimizeAndRestore) {
+ TestMinimizeAndRestore();
+}
#endif

Powered by Google App Engine
This is Rietveld 408576698