Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 7239022: Show singleton tab instead of opening multiple help tabs (Closed)

Created:
9 years, 6 months ago by keishi-hattori
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Show singleton tab instead of opening multiple help tabs BUG=87356 TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
keishi-hattori
I'm not sure if this is a good idea but I didn't see why not.
9 years, 6 months ago (2011-06-24 10:56:49 UTC) #1
Ben Goodger (Google)
LGTM
9 years, 6 months ago (2011-06-24 15:08:03 UTC) #2
Nikita (slow)
LGTM
9 years, 6 months ago (2011-06-24 17:58:40 UTC) #3
commit-bot: I haz the power
Presubmit check for 7239022-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 6 months ago (2011-06-26 17:30:59 UTC) #4
keishi-hattori
On 2011/06/26 17:30:59, I haz the power (commit-bot) wrote: > Presubmit check for 7239022-1 failed ...
9 years, 5 months ago (2011-06-28 09:37:52 UTC) #5
Nikita (slow)
Please check "commit" checkbox right below the patchset. This will commit on your behalf.
9 years, 5 months ago (2011-07-06 10:40:42 UTC) #6
Nikita (slow)
9 years, 5 months ago (2011-07-06 10:41:33 UTC) #7
On 2011/07/06 10:40:42, Nikita Kostylev wrote:
> Please check "commit" checkbox right below the patchset.
> This will commit on your behalf.

Ok, I've read commit-bot error message now.

Powered by Google App Engine
This is Rietveld 408576698