Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3819)

Unified Diff: chrome/browser/ui/browser.cc

Issue 7239022: Show singleton tab instead of opening multiple help tabs (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 8658e4f1631fa4e91fdc2f42eabc645a20fed6b8..e005f76d19c4cf4cfd4e0d2cc3ac43752e5d5d1b 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -740,7 +740,7 @@ void Browser::OpenDownloadsWindow(Profile* profile) {
// static
void Browser::OpenHelpWindow(Profile* profile) {
Browser* browser = Browser::Create(profile);
- browser->OpenHelpTab();
+ browser->ShowHelpTab();
browser->window()->Show();
}
@@ -2045,10 +2045,10 @@ void Browser::OpenUpdateChromeDialog() {
window_->ShowUpdateChromeDialog();
}
-void Browser::OpenHelpTab() {
+void Browser::ShowHelpTab() {
GURL help_url(kHelpContentUrl);
GURL localized_help_url = google_util::AppendGoogleLocaleParam(help_url);
- AddSelectedTabWithURL(localized_help_url, PageTransition::AUTO_BOOKMARK);
+ ShowSingletonTab(localized_help_url);
}
void Browser::OpenThemeGalleryTabAndActivate() {
@@ -2475,7 +2475,7 @@ void Browser::ExecuteCommandWithDisposition(
case IDC_ABOUT: OpenAboutChromeDialog(); break;
case IDC_UPGRADE_DIALOG: OpenUpdateChromeDialog(); break;
case IDC_VIEW_INCOMPATIBILITIES: ShowAboutConflictsTab(); break;
- case IDC_HELP_PAGE: OpenHelpTab(); break;
+ case IDC_HELP_PAGE: ShowHelpTab(); break;
#if defined(OS_CHROMEOS)
case IDC_FILE_MANAGER: OpenFileManager(); break;
case IDC_SYSTEM_OPTIONS: OpenSystemOptionsDialog(); break;
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698