Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2268)

Side by Side Diff: chrome/browser/app_controller_mac.mm

Issue 7239022: Show singleton tab instead of opening multiple help tabs (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/browser.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/app_controller_mac.h" 5 #import "chrome/browser/app_controller_mac.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #include "base/mac/foundation_util.h" 10 #include "base/mac/foundation_util.h"
(...skipping 817 matching lines...) Expand 10 before | Expand all | Expand 10 after
828 Browser::OpenDownloadsWindow(lastProfile); 828 Browser::OpenDownloadsWindow(lastProfile);
829 break; 829 break;
830 case IDC_MANAGE_EXTENSIONS: 830 case IDC_MANAGE_EXTENSIONS:
831 if (Browser* browser = ActivateBrowser(lastProfile)) 831 if (Browser* browser = ActivateBrowser(lastProfile))
832 browser->ShowExtensionsTab(); 832 browser->ShowExtensionsTab();
833 else 833 else
834 Browser::OpenExtensionsWindow(lastProfile); 834 Browser::OpenExtensionsWindow(lastProfile);
835 break; 835 break;
836 case IDC_HELP_PAGE: 836 case IDC_HELP_PAGE:
837 if (Browser* browser = ActivateBrowser(lastProfile)) 837 if (Browser* browser = ActivateBrowser(lastProfile))
838 browser->OpenHelpTab(); 838 browser->ShowHelpTab();
839 else 839 else
840 Browser::OpenHelpWindow(lastProfile); 840 Browser::OpenHelpWindow(lastProfile);
841 break; 841 break;
842 case IDC_FEEDBACK: { 842 case IDC_FEEDBACK: {
843 Browser* browser = BrowserList::GetLastActive(); 843 Browser* browser = BrowserList::GetLastActive();
844 TabContents* currentTab = 844 TabContents* currentTab =
845 browser ? browser->GetSelectedTabContents() : NULL; 845 browser ? browser->GetSelectedTabContents() : NULL;
846 BugReportWindowController* controller = 846 BugReportWindowController* controller =
847 [[BugReportWindowController alloc] 847 [[BugReportWindowController alloc]
848 initWithTabContents:currentTab 848 initWithTabContents:currentTab
(...skipping 358 matching lines...) Expand 10 before | Expand all | Expand 10 after
1207 1207
1208 } // namespace browser 1208 } // namespace browser
1209 1209
1210 namespace app_controller_mac { 1210 namespace app_controller_mac {
1211 1211
1212 bool IsOpeningNewWindow() { 1212 bool IsOpeningNewWindow() {
1213 return g_is_opening_new_window; 1213 return g_is_opening_new_window;
1214 } 1214 }
1215 1215
1216 } // namespace app_controller_mac 1216 } // namespace app_controller_mac
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/browser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698