Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Issue 7230028: The crash service starup code in the cf net tests suite relies on the AtExitManager instance bein... (Closed)

Created:
9 years, 5 months ago by ananta
Modified:
9 years, 5 months ago
Reviewers:
robertshield
CC:
chromium-reviews, amit, darin-cc_chromium.org, cbentzel+watch_chromium.org
Visibility:
Public.

Description

The crash service starup code in the cf net tests suite relies on the AtExitManager instance being around. Moving this to after the test suite initialization fixes the DCHECKs firing in debug builds if the crash service isn't already running. BUG=none TEST=cf net tests should run in debug builds without DCHECKs TBR=robertshield Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome_frame/test/net/fake_external_tab.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ananta
9 years, 5 months ago (2011-06-27 20:18:49 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698