Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome_frame/test/net/fake_external_tab.cc

Issue 7230028: The crash service starup code in the cf net tests suite relies on the AtExitManager instance bein... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/net/fake_external_tab.cc
===================================================================
--- chrome_frame/test/net/fake_external_tab.cc (revision 90597)
+++ chrome_frame/test/net/fake_external_tab.cc (working copy)
@@ -552,8 +552,6 @@
return 0;
}
- base::ProcessHandle crash_service = chrome_frame_test::StartCrashService();
-
google_breakpad::scoped_ptr<google_breakpad::ExceptionHandler> breakpad(
InitializeCrashReporting(HEADLESS));
@@ -563,6 +561,8 @@
// below require. So we have to instantiate this first.
CFUrlRequestUnittestRunner test_suite(argc, argv);
+ base::ProcessHandle crash_service = chrome_frame_test::StartCrashService();
+
WindowWatchdog watchdog;
// See url_request_unittest.cc for these credentials.
SupplyProxyCredentials credentials("user", "secret");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698