Issue 7230028: The crash service starup code in the cf net tests suite relies on the AtExitManager instance bein...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7230028: The crash service starup code in the cf net tests suite relies on the AtExitManager instance bein... (Closed)

Created:
9 years, 5 months ago by ananta

Modified:
9 years, 5 months ago

Reviewers:
robertshield

CC:
chromium-reviews, amit, darin-cc_chromium.org, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

The crash service starup code in the cf net tests suite relies on the AtExitManager instance being around. Moving this to after the test suite initialization fixes the DCHECKs firing in debug builds if the crash service isn't already running. BUG=none TEST=cf net tests should run in debug builds without DCHECKs TBR=robertshield Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90630

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome_frame/test/net/fake_external_tab.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages