Improve and unify Mac OS X run-time version checks

Improve and unify Mac OS X run-time version checks.

Don't use base::SysInfo::OperatingSystemVersionNumbers, because it calls
Gestalt, which has a few bad properties. Introduce new functions that perform
specific version checks.

BUG=85972
TEST=base_unittests MacUtilTest.IsOSEllipsis
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89028

[scherkus (not reviewing), 2011-06-13 22:40:37]

LGTM on media

[Avi (use Gerrit), 2011-06-13 22:45:22]

LGTM

http://codereview.chromium.org/7144007/diff/1/base/mac/mac_util.mm
File base/mac/mac_util.mm (right):

http://codereview.chromium.org/7144007/diff/1/base/mac/mac_util.mm#newcode17
base/mac/mac_util.mm:17: #include "base/string_number_conversions.h"
alphabetize

http://codereview.chromium.org/7144007/diff/1/chrome/browser/bug_report_util.cc
File chrome/browser/bug_report_util.cc (right):

http://codereview.chromium.org/7144007/diff/1/chrome/browser/bug_report_util....
chrome/browser/bug_report_util.cc:170: *os_version =
base::SysInfo::OperatingSystemVersion();
DCHECK? NOTIMPLEMENTED?

[Mark Mentovai, 2011-06-14 00:18:25]

http://codereview.chromium.org/7144007/diff/1/base/mac/mac_util.mm
File base/mac/mac_util.mm (right):

http://codereview.chromium.org/7144007/diff/1/base/mac/mac_util.mm#newcode17
base/mac/mac_util.mm:17: #include "base/string_number_conversions.h"
Avi wrote:
> alphabetize

OOPS!

http://codereview.chromium.org/7144007/diff/1/chrome/browser/bug_report_util.cc
File chrome/browser/bug_report_util.cc (right):

http://codereview.chromium.org/7144007/diff/1/chrome/browser/bug_report_util....
chrome/browser/bug_report_util.cc:170: *os_version =
base::SysInfo::OperatingSystemVersion();
Avi wrote:
> DCHECK? NOTIMPLEMENTED?

I don’t get it. What would you DCHECK or NOTIMPLEMENTED here?

The Mac’s base::SysInfo::OperatingSystemVersion (base/sys_info_mac.cc) does
|base::StringPrintf("%d.%d.%d", major, minor, bugfix)| in exactly the same way
as the code that had been here.

[Avi (use Gerrit), 2011-06-14 01:40:22]

http://codereview.chromium.org/7144007/diff/1/chrome/browser/bug_report_util.cc
File chrome/browser/bug_report_util.cc (right):

http://codereview.chromium.org/7144007/diff/1/chrome/browser/bug_report_util....
chrome/browser/bug_report_util.cc:170: *os_version =
base::SysInfo::OperatingSystemVersion();
Misread. My bad.

[Mark Mentovai, 2011-06-14 02:59:41]

jam for OWNERS approval too

[jam, 2011-06-14 06:29:17]

content lgtm

[Mark Mentovai, 2011-06-14 17:00:45]

Avi, one more look? I added some minor clean-ups, added an optimization for when
the deployment target is set, and replaced a use of
std::floor(NSAppKitVersionNumber) with this API.

[Avi (use Gerrit), 2011-06-14 17:50:17]

SLGTM with comments.

http://codereview.chromium.org/7144007/diff/1025/base/sys_info.h
File base/sys_info.h (right):

http://codereview.chromium.org/7144007/diff/1025/base/sys_info.h#newcode48
base/sys_info.h:48: // base/win/windows_version.h.
Is there any use left for this function, then?

http://codereview.chromium.org/7144007/diff/1025/ui/base/resource/resource_bu...
File ui/base/resource/resource_bundle_mac.mm (right):

http://codereview.chromium.org/7144007/diff/1025/ui/base/resource/resource_bu...
ui/base/resource/resource_bundle_mac.mm:50: // Only load the large resource pak
on if we're running on 10.7 or above.
drop "on": "... pak if we're running ..."

[Mark Mentovai, 2011-06-14 18:00:18]

http://codereview.chromium.org/7144007/diff/1025/base/sys_info.h
File base/sys_info.h (right):

http://codereview.chromium.org/7144007/diff/1025/base/sys_info.h#newcode48
base/sys_info.h:48: // base/win/windows_version.h.
Avi wrote:
> Is there any use left for this function, then?

Yes, there are still two or three mofos left that use it to format the version
number themselves. For example, the user agent string on Mac is formatted as
10_6_7.

I have a separate change (http://codereview.chromium.org/7150018) to transition
the Windows callers that were using this instead of the API I recommended. (On
Windows, OperatingSystemVersionNumbers is actually implemented on
base::win::OSInfo.)

http://codereview.chromium.org/7144007/diff/1025/ui/base/resource/resource_bu...
File ui/base/resource/resource_bundle_mac.mm (right):

http://codereview.chromium.org/7144007/diff/1025/ui/base/resource/resource_bu...
ui/base/resource/resource_bundle_mac.mm:50: // Only load the large resource pak
on if we're running on 10.7 or above.
Avi wrote:
> drop "on": "... pak if we're running ..."

Good catch.