Use GetVersion for Windows run-time version checks in preference to OperatingSystemVersionNumbers

Use base::win::GetVersion for Windows run-time version checks in preference to
base::SysInfo::OperatingSystemVersionNumbers. The latter is just a
harder-to-use wrapper around the former.

BUG=86062
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89055

[Mark Mentovai, 2011-06-14 18:17:27]

wtc, I chose you for net OWNERS approval. It’s also a pretty simple change, so
I’ll accept your review for the entire thing.

[wtc, 2011-06-14 18:35:30]

LGTM.

http://codereview.chromium.org/7150018/diff/1/chrome/renderer/localized_error.cc
File chrome/renderer/localized_error.cc (right):

http://codereview.chromium.org/7150018/diff/1/chrome/renderer/localized_error...
chrome/renderer/localized_error.cc:457: }
It seems that we should also have a custom string for Windows 7.

[Mark Mentovai, 2011-06-14 19:22:07]

http://codereview.chromium.org/7150018/diff/1/chrome/renderer/localized_error.cc
File chrome/renderer/localized_error.cc (right):

http://codereview.chromium.org/7150018/diff/1/chrome/renderer/localized_error...
chrome/renderer/localized_error.cc:457: }
wtc wrote:
> It seems that we should also have a custom string for Windows 7.

This confused me too. Windows 7 uses
IDS_ERRORPAGES_SUMMARY_INTERNET_DISCONNECTED_PLATFORM, which is the initial
value of platform_string_id from line 444. The relevant definition in
chrome/app/generated_resources.grd is:

        <message name="IDS_ERRORPAGES_SUMMARY_INTERNET_DISCONNECTED_PLATFORM"
desc="Summary (platform dependent section) in the error page when the network
connection failed.  Describes how to get to the network Diagnostics screen under
Windows 7 and later.">
          Go to
          <ph name="BEGIN_BOLD">&lt;strong&gt;</ph>
          Start &gt; Control Panel &gt; Network and Internet &gt; Network and
Sharing Center &gt; Troubleshoot Problems (at the bottom) &gt; Internet
Connections.
          <ph name="END_BOLD">&lt;/strong&gt;</ph>
        </message>

This string will also be used for Windows Server 2008. I’m not sure if that’s
correct or if that release should use the Vista message or something else. I
also have no way to check this, so I left the Vista message for Vista and Vista
only, which is what the existing code did.