Multi-tab: Fixing TabStripSelectionModel::SetSelectedIndex corner case.

Multi-tab: Fixing TabStripSelectionModel::SetSelectedIndex corner case.

BUG=Invoking SetSelectedIndex(-1) results in stack overflow.
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88433

[dpapad, 2011-06-08 20:35:21]

This should fix the problem, right? I did not put it in
http://codereview.chromium.org/7033048/ because it might take a while until
updating the unit tests.

[sky, 2011-06-08 20:38:49]

TabStripSelectionModel has some tests. Could you add add coverage for this?

http://codereview.chromium.org/7140001/diff/1/chrome/browser/tabs/tab_strip_s...
File chrome/browser/tabs/tab_strip_selection_model.cc (right):

http://codereview.chromium.org/7140001/diff/1/chrome/browser/tabs/tab_strip_s...
chrome/browser/tabs/tab_strip_selection_model.cc:63:
selected_indices_.push_back(index);
Only push_back if index != kUnselectedIndex.

[dpapad, 2011-06-08 21:19:34]

http://codereview.chromium.org/7140001/diff/1/chrome/browser/tabs/tab_strip_s...
File chrome/browser/tabs/tab_strip_selection_model.cc (right):

http://codereview.chromium.org/7140001/diff/1/chrome/browser/tabs/tab_strip_s...
chrome/browser/tabs/tab_strip_selection_model.cc:63:
selected_indices_.push_back(index);
On 2011/06/08 20:38:49, sky wrote:
> Only push_back if index != kUnselectedIndex.

Done.

http://codereview.chromium.org/7140001/diff/4001/chrome/browser/tabs/tab_stri...
File chrome/browser/tabs/tab_strip_selection_model_unittest.cc (right):

http://codereview.chromium.org/7140001/diff/4001/chrome/browser/tabs/tab_stri...
chrome/browser/tabs/tab_strip_selection_model_unittest.cc:43:
TEST_F(TabStripSelectionModelTest, SetSelectedIndexToEmpty) {
Is this ok, or should it be moved within the previous test?

[sky, 2011-06-08 21:59:23]

LGTM

http://codereview.chromium.org/7140001/diff/4001/chrome/browser/tabs/tab_stri...
File chrome/browser/tabs/tab_strip_selection_model_unittest.cc (right):

http://codereview.chromium.org/7140001/diff/4001/chrome/browser/tabs/tab_stri...
chrome/browser/tabs/tab_strip_selection_model_unittest.cc:43:
TEST_F(TabStripSelectionModelTest, SetSelectedIndexToEmpty) {
On 2011/06/08 21:19:34, dpapad wrote:
> Is this ok, or should it be moved within the previous test?

Standalone test is fine by me.

[commit-bot: I haz the power, 2011-06-08 22:56:06]

Change committed as 88433