chrome/browser/tabs/tab_strip_selection_model.cc - Issue 7140001: Multi-tab: Fixing TabStripSelectionModel::SetSelectedIndex corner case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tabs/tab_strip_selection_model.cc

Issue 7140001: Multi-tab: Fixing TabStripSelectionModel::SetSelectedIndex corner case. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adding unit tests Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/tabs/tab_strip_selection_model.cc

diff --git a/chrome/browser/tabs/tab_strip_selection_model.cc b/chrome/browser/tabs/tab_strip_selection_model.cc

index 1164b28f7cb006a32e609df8ac394f84a3f3e687..43757c3ccd029fda240479438ca3dc7250c5ae49 100644

--- a/chrome/browser/tabs/tab_strip_selection_model.cc

+++ b/chrome/browser/tabs/tab_strip_selection_model.cc

@@ -59,7 +59,9 @@ void TabStripSelectionModel::DecrementFrom(int index) {

void TabStripSelectionModel::SetSelectedIndex(int index) {

anchor_ = active_ = index;

- SetSelectionFromAnchorTo(index);

+ selected_indices_.clear();

+ if (index != kUnselectedIndex)

+ selected_indices_.push_back(index);

}

bool TabStripSelectionModel::IsSelected(int index) const {