Multi-tab: Fixing TabStripSelectionModel::SetSelectedIndex corner case.

chrome/browser/tabs/tab_strip_selection_model_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <string>
 
 #include "base/string_number_conversions.h"
 #include "chrome/browser/tabs/tab_strip_selection_model.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 22 matching lines @@
   EXPECT_TRUE(model.empty());
 }
 
 TEST_F(TabStripSelectionModelTest, SetSelectedIndex) {
   TabStripSelectionModel model;
   model.SetSelectedIndex(2);
   EXPECT_EQ("active=2 anchor=2 selection=2", StateAsString(model));
   EXPECT_FALSE(model.empty());
 }
 
+TEST_F(TabStripSelectionModelTest, SetSelectedIndexToEmpty) {

[dpapad, 2011/06/08 21:19:34]

Is this ok, or should it be moved within the previous test?

[sky, 2011/06/08 21:59:23]

Standalone test is fine by me.

+  TabStripSelectionModel model;
+  model.SetSelectedIndex(-1);
+  EXPECT_EQ("active=-1 anchor=-1 selection=", StateAsString(model));
+  EXPECT_TRUE(model.empty());
+}
+
 TEST_F(TabStripSelectionModelTest, IncrementFrom) {
   TabStripSelectionModel model;
   model.SetSelectedIndex(1);
   model.IncrementFrom(1);
   EXPECT_EQ("active=2 anchor=2 selection=2", StateAsString(model));
 
   // Increment from 4. This shouldn't effect the selection as its past the
   // end of the selection.
   model.IncrementFrom(4);
   EXPECT_EQ("active=2 anchor=2 selection=2", StateAsString(model));
@@ skipping 39 matching lines @@
   model.AddIndexToSelection(4);
   EXPECT_EQ("active=2 anchor=2 selection=2 4", StateAsString(model));
 
   model.RemoveIndexFromSelection(4);
   EXPECT_EQ("active=2 anchor=2 selection=2", StateAsString(model));
 
   model.RemoveIndexFromSelection(2);
   EXPECT_EQ("active=2 anchor=2 selection=", StateAsString(model));
 }
 
+TEST_F(TabStripSelectionModelTest, SetSelectionFromAnchorTo) {
+  TabStripSelectionModel model;
+  model.SetSelectedIndex(2);
+  model.SetSelectionFromAnchorTo(7);
+  EXPECT_EQ("active=7 anchor=2 selection=2 3 4 5 6 7", StateAsString(model));
+
+  model.Clear();
+  model.SetSelectedIndex(7);
+  model.SetSelectionFromAnchorTo(2);
+  EXPECT_EQ("active=2 anchor=7 selection=2 3 4 5 6 7", StateAsString(model));
+
+  model.Clear();
+  model.SetSelectionFromAnchorTo(7);
+  EXPECT_EQ("active=7 anchor=7 selection=7", StateAsString(model));
+}
+
 TEST_F(TabStripSelectionModelTest, Clear) {
   TabStripSelectionModel model;
   model.SetSelectedIndex(2);
 
   model.Clear();
   EXPECT_EQ("active=-1 anchor=-1 selection=", StateAsString(model));
 }
 
 TEST_F(TabStripSelectionModelTest, MoveToLeft) {
   TabStripSelectionModel model;
@@ skipping 31 matching lines @@
 TEST_F(TabStripSelectionModelTest, AddSelectionFromAnchorTo) {
   TabStripSelectionModel model;
   model.SetSelectedIndex(2);
 
   model.AddSelectionFromAnchorTo(4);
   EXPECT_EQ("active=4 anchor=2 selection=2 3 4", StateAsString(model));
 
   model.AddSelectionFromAnchorTo(0);
   EXPECT_EQ("active=0 anchor=2 selection=0 1 2 3 4", StateAsString(model));
 }