Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 7134042: Link function contexts directly to the previous context. (Closed)

Created:
9 years, 6 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Link function contexts directly to the previous context. Instead of NULL in the previous field of function contexts, put the previous context. This saves the indirection of fetching the previous through the context's closure. R=ager@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8238

Patch Set 1 #

Patch Set 2 : Small improvements. #

Patch Set 3 : Avoid calling previous on the global context. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -49 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/contexts.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/contexts.cc View 1 2 4 chunks +7 lines, -8 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/runtime.cc View 1 2 chunks +2 lines, -10 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 6 months ago (2011-06-09 11:48:20 UTC) #1
Mads Ager (chromium)
9 years, 6 months ago (2011-06-09 11:52:08 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698