src/arm/code-stubs-arm.cc - Issue 7134042: Link function contexts directly to the previous context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/code-stubs-arm.cc

Issue 7134042: Link function contexts directly to the previous context. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Avoid calling previous on the global context. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/code-stubs-arm.cc

diff --git a/src/arm/code-stubs-arm.cc b/src/arm/code-stubs-arm.cc

index 6f6d13d45ce56c9e9eff1b2f561ec19bdffe5360..4ecf2fb86cea1a42e29f5347d3c8fcdcb848d82b 100644

--- a/src/arm/code-stubs-arm.cc

+++ b/src/arm/code-stubs-arm.cc

@@ -167,10 +167,10 @@ void FastNewContextStub::Generate(MacroAssembler* masm) {

__ mov(r1, Operand(Smi::FromInt(0)));

__ str(r3, MemOperand(r0, Context::SlotOffset(Context::CLOSURE_INDEX)));

__ str(r0, MemOperand(r0, Context::SlotOffset(Context::FCONTEXT_INDEX)));

- __ str(r1, MemOperand(r0, Context::SlotOffset(Context::PREVIOUS_INDEX)));

+ __ str(cp, MemOperand(r0, Context::SlotOffset(Context::PREVIOUS_INDEX)));

__ str(r1, MemOperand(r0, Context::SlotOffset(Context::EXTENSION_INDEX)));

- // Copy the global object from the surrounding context.

+ // Copy the global object from the previous context.

__ ldr(r1, MemOperand(cp, Context::SlotOffset(Context::GLOBAL_INDEX)));

__ str(r1, MemOperand(r0, Context::SlotOffset(Context::GLOBAL_INDEX)));

« no previous file with comments | « no previous file | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »