src/x64/code-stubs-x64.cc - Issue 7134042: Link function contexts directly to the previous context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/code-stubs-x64.cc

Issue 7134042: Link function contexts directly to the previous context. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Avoid calling previous on the global context. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/code-stubs-x64.cc

diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc

index 35cff704681525c38b7141732432850f9c86293c..09b127779a87c1e67ab7281f6993c93f4c56f28d 100644

--- a/src/x64/code-stubs-x64.cc

+++ b/src/x64/code-stubs-x64.cc

@@ -133,10 +133,10 @@ void FastNewContextStub::Generate(MacroAssembler* masm) {

__ Set(rbx, 0); // Set to NULL.

__ movq(Operand(rax, Context::SlotOffset(Context::CLOSURE_INDEX)), rcx);

__ movq(Operand(rax, Context::SlotOffset(Context::FCONTEXT_INDEX)), rax);

- __ movq(Operand(rax, Context::SlotOffset(Context::PREVIOUS_INDEX)), rbx);

+ __ movq(Operand(rax, Context::SlotOffset(Context::PREVIOUS_INDEX)), rsi);

__ movq(Operand(rax, Context::SlotOffset(Context::EXTENSION_INDEX)), rbx);

- // Copy the global object from the surrounding context.

+ // Copy the global object from the previous context.

__ movq(rbx, Operand(rsi, Context::SlotOffset(Context::GLOBAL_INDEX)));

__ movq(Operand(rax, Context::SlotOffset(Context::GLOBAL_INDEX)), rbx);

« no previous file with comments | « src/runtime.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »