Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6575)

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 7131001: Partially deprecate the old webstorePrivate.beginInstall method (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: moved observing to helper object Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/crx_installer_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer.cc
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index 86a7f396eda5a8583423f155e200206f83524c0c..e772a0f2bcafc2cbb0b499daac4a9247cea6c707 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -392,11 +392,10 @@ void CrxInstaller::ConfirmInstall() {
current_version_ =
frontend_weak_->extension_prefs()->GetVersionString(extension_->id());
- // First see if it's whitelisted by id (the old mechanism).
- bool whitelisted = ClearWhitelistedInstallId(extension_->id()) &&
- extension_->plugins().empty() && is_gallery_install_;
+ // TODO(asargent) - remove this when we fully deprecate the old install api.
+ ClearWhitelistedInstallId(extension_->id());
- // Now check if there's a WhitelistEntry.
+ bool whitelisted = false;
scoped_ptr<CrxInstaller::WhitelistEntry> entry(
RemoveWhitelistEntry(extension_->id()));
if (is_gallery_install_ && entry.get() && original_manifest_.get()) {
« no previous file with comments | « no previous file | chrome/browser/extensions/crx_installer_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698