Partially deprecate the old webstorePrivate.beginInstall method

chrome/browser/extensions/extension_gallery_install_apitest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/stringprintf.h"
 #if defined (OS_WIN)
 #include "base/win/windows_version.h"
 #endif  // defined (OS_WIN)
 
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_webstore_private_api.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/ui_test_utils.h"
+#include "content/common/notification_observer.h"
+#include "content/common/notification_registrar.h"
+#include "content/common/notification_service.h"
+#include "content/common/notification_type.h"
 #include "net/base/mock_host_resolver.h"
 
 class ExtensionGalleryInstallApiTest : public ExtensionApiTest {
  public:
   void SetUpCommandLine(CommandLine* command_line) {
     ExtensionApiTest::SetUpCommandLine(command_line);
     command_line->AppendSwitchASCII(switches::kAppsGalleryURL,
         "http://www.example.com");
   }
 
   bool RunInstallTest(const std::string& page) {
+    NotificationRegistrar registrar;
+    registrar.Add(this,
+                  NotificationType::EXTENSION_WILL_SHOW_CONFIRM_DIALOG,
+                  NotificationService::AllSources());
     std::string base_url = base::StringPrintf(
         "http://www.example.com:%u/files/extensions/",
         test_server()->host_port_pair().port());
 
     std::string testing_install_base_url = base_url;
     testing_install_base_url += "good.crx";
 
     CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       switches::kAppsGalleryUpdateURL, testing_install_base_url);
 
     std::string page_url = base_url;
     page_url += "api_test/extension_gallery_install/" + page;
 
     return RunPageTest(page_url.c_str());
   }
+
+  void InstallUIProceed(ExtensionInstallUI::Delegate* delegate) {
+    delegate->InstallUIProceed();
+  }
+
+  // We implement the NotificationObserver interface to drive the install
+  // dialog.
+  virtual void Observe(NotificationType type,

[Matt Perry, 2011/06/07 18:03:30]

Don't you need to call the parent class' Observe? Also, you're not guaranteed to
be getting the EXTENSION_WILL_SHOW_CONFIRM_DIALOG notification, since the base
class could subscribe to some.

+                       const NotificationSource& source,
+                       const NotificationDetails& details) OVERRIDE {
+    ExtensionInstallUI* prompt = Source<ExtensionInstallUI>(source).ptr();
+    CHECK(prompt->delegate_);
+    MessageLoop::current()->PostTask(
+        FROM_HERE, NewRunnableMethod(
+            this,
+            &ExtensionGalleryInstallApiTest::InstallUIProceed,
+            prompt->delegate_));
+  }
 };
 
 namespace {
 
 bool RunningOnXP() {
 #if defined (OS_WIN)
   return GetVersion() < base::win::VERSION_VISTA;
 #else
   return false;
 #endif  // defined (OS_WIN)
@@ skipping 26 matching lines @@
   ASSERT_TRUE(RunInstallTest("test.html"));
   ASSERT_TRUE(RunInstallTest("complete_without_begin.html"));
   ASSERT_TRUE(RunInstallTest("invalid_begin.html"));
 
   if (RunningOnXP()) {
     LOG(INFO) << "Starting tests with user gesture checking";
   }
   BeginInstallFunction::SetIgnoreUserGestureForTests(false);
   ASSERT_TRUE(RunInstallTest("no_user_gesture.html"));
 }