Issue 7129006: Make EstablishGpuChannel synchronous. Remove obsolete Synchronize msg.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7129006: Make EstablishGpuChannel synchronous. Remove obsolete Synchronize msg. (Closed)

Created:
9 years, 6 months ago by no sievers

Modified:
9 years, 6 months ago

Reviewers:
jam, apatrick_chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, apatrick_chromium, nduca, klobag.chromium

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Make EstablishGpuChannel synchronous. Remove obsolete Synchronize msg. This simplifies message routing to the compositor thread a bit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88387

Patch Set 1 #

Patch Set 2 : remove obsolete declaration #

Total comments: 1

Patch Set 3 : fix indentation and rebase #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -163 lines)			Patch
M	content/browser/gpu/gpu_process_host.h	View		4 chunks	+0 lines, -11 lines	0 comments	Download
M	content/browser/gpu/gpu_process_host.cc	View		5 chunks	+0 lines, -33 lines	0 comments	Download
M	content/browser/renderer_host/gpu_message_filter.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/gpu_message_filter.cc	View		6 chunks	+16 lines, -54 lines	0 comments	Download
M	content/common/gpu/gpu_channel_manager.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/common/gpu/gpu_channel_manager.cc	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	content/common/gpu/gpu_messages.h	View	1 2	4 chunks	+5 lines, -24 lines	0 comments	Download
M	content/renderer/render_thread.h	View	1	2 chunks	+0 lines, -8 lines	0 comments	Download
M	content/renderer/render_thread.cc	View	1 2	4 chunks	+21 lines, -25 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

LGTM http://codereview.chromium.org/7129006/diff/2001/content/renderer/render_thread.cc File content/renderer/render_thread.cc (right): http://codereview.chromium.org/7129006/diff/2001/content/renderer/render_thread.cc#newcode494 content/renderer/render_thread.cc:494: // Otherwise cancel the connection. indentation is out

9 years, 6 months ago (2011-06-08 18:12:35 UTC) #2

Expand Messages | Collapse Messages