Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 7125006: Get rid of Chrome notifications dependency, and instead go through ContentBrowserClient to show U... (Closed)

Created:
9 years, 6 months ago by jam
Modified:
9 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, Avi (use Gerrit), brettw-cc_chromium.org
Visibility:
Public.

Description

Get rid of Chrome notifications dependency, and instead go through ContentBrowserClient to show UI. Also the Chrome notifications code now calls methods in RenderViewHost instead of directly sending the content layer IPCs. BUG=76697 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88234

Patch Set 1 : '' #

Patch Set 2 : fix browsertest #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -251 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 5 chunks +86 lines, -2 lines 0 comments Download
D chrome/browser/desktop_notification_handler.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/desktop_notification_handler.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/desktop_notification_handler_stub.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/notifications/notification_object_proxy.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/notifications/notification_object_proxy.cc View 2 chunks +17 lines, -26 lines 0 comments Download
M chrome/browser/notifications/notifications_prefs_cache.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/notifications/notifications_prefs_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 5 chunks +15 lines, -5 lines 1 comment Download
M chrome/browser/profiles/profile_io_data.cc View 4 chunks +12 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/DEPS View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/content_browser_client.h View 4 chunks +32 lines, -1 line 0 comments Download
M content/browser/content_browser_client.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 3 chunks +2 lines, -19 lines 0 comments Download
M content/browser/renderer_host/render_view_host.h View 3 chunks +14 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 4 chunks +61 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
9 years, 6 months ago (2011-06-07 16:47:47 UTC) #1
ananta
LGTM
9 years, 6 months ago (2011-06-07 17:32:16 UTC) #2
willchan no longer on Chromium
9 years, 5 months ago (2011-06-28 09:08:40 UTC) #3
Please add me for ProfileIOData changes in the future.

http://codereview.chromium.org/7125006/diff/9001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_io_data.h (right):

http://codereview.chromium.org/7125006/diff/9001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_io_data.h:261: mutable
DesktopNotificationService* notification_service_;
Isn't this a bug? DesktopNotificationService is owned and destroyed on the UI
thread when the ProfileManager is destroyed, which is before the IO thread is
stopped. Does this lead to shutdown use-after-free?

Powered by Google App Engine
This is Rietveld 408576698