Get rid of Chrome notifications dependency, and instead go through ContentBrowserClient to show U...

chrome/browser/profiles/profile_io_data.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
 #pragma once
 
 #include <set>
 #include "base/basictypes.h"
 #include "base/debug/stack_trace.h"
 #include "base/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/synchronization/lock.h"
 #include "chrome/browser/net/chrome_url_request_context.h"
 #include "chrome/browser/prefs/pref_member.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/browser/resource_context.h"
 #include "net/base/cookie_monster.h"
 
 class CommandLine;
 class ChromeAppCacheService;
 class ChromeBlobStorageContext;
+class DesktopNotificationService;
 class ExtensionInfoMap;
+class HostContentSettingsMap;
+class HostZoomMap;
+class IOThread;
+class ProtocolHandlerRegistry;
+
 namespace fileapi {
 class FileSystemContext;
 }  // namespace fileapi
-class HostContentSettingsMap;
-class HostZoomMap;
-class IOThread;
+
 namespace net {
 class DnsCertProvenanceChecker;
 class NetLog;
 class ProxyConfigService;
 class ProxyService;
 class SSLConfigService;
 class TransportSecurityState;
 }  // namespace net
+
 namespace prerender {
 class PrerenderManager;
 };  // namespace prerender
-class ProtocolHandlerRegistry;
+
 namespace quota {
 class QuotaManager;
 };  // namespace quota
+
 namespace webkit_database {
 class DatabaseTracker;
 }  // webkit_database
 
 // Conceptually speaking, the ProfileIOData represents data that lives on the IO
 // thread that is owned by a Profile, such as, but not limited to, network
 // objects like CookieMonster, HttpTransactionFactory, etc. The Profile
 // implementation will maintain a reference to the ProfileIOData. The
 // ProfileIOData will originally own a reference to the ChromeURLRequestContexts
 // that reference its members. When an accessor for a ChromeURLRequestContext is
@@ skipping 21 matching lines @@
   scoped_refptr<ChromeURLRequestContext> GetMediaRequestContext() const;
   scoped_refptr<ChromeURLRequestContext> GetExtensionsRequestContext() const;
   scoped_refptr<ChromeURLRequestContext> GetIsolatedAppRequestContext(
       scoped_refptr<ChromeURLRequestContext> main_context,
       const std::string& app_id) const;
   const content::ResourceContext& GetResourceContext() const;
 
   // These are useful when the Chrome layer is called from the content layer
   // with a content::ResourceContext, and they want access to Chrome data for
   // that profile.
+  ExtensionInfoMap* GetExtensionInfoMap() const;
   HostContentSettingsMap* GetHostContentSettingsMap() const;
+  DesktopNotificationService* GetNotificationService() const;
 
  protected:
   friend class base::RefCountedThreadSafe<ProfileIOData>;
 
   class RequestContext : public ChromeURLRequestContext {
    public:
     RequestContext();
     virtual ~RequestContext();
 
     // Setter is used to transfer ownership of the ProfileIOData to the context.
@@ skipping 21 matching lines @@
     scoped_refptr<HostZoomMap> host_zoom_map;
     scoped_refptr<net::TransportSecurityState> transport_security_state;
     scoped_refptr<net::SSLConfigService> ssl_config_service;
     scoped_refptr<net::CookieMonster::Delegate> cookie_monster_delegate;
     scoped_refptr<webkit_database::DatabaseTracker> database_tracker;
     scoped_refptr<ChromeAppCacheService> appcache_service;
     scoped_refptr<ChromeBlobStorageContext> blob_storage_context;
     scoped_refptr<fileapi::FileSystemContext> file_system_context;
     scoped_refptr<quota::QuotaManager> quota_manager;
     scoped_refptr<ExtensionInfoMap> extension_info_map;
+    DesktopNotificationService* notification_service;
     base::WeakPtr<prerender::PrerenderManager> prerender_manager;
     scoped_refptr<ProtocolHandlerRegistry> protocol_handler_registry;
     // We need to initialize the ProxyConfigService from the UI thread
     // because on linux it relies on initializing things through gconf,
     // and needs to be on the main thread.
     scoped_ptr<net::ProxyConfigService> proxy_config_service;
     // The profile this struct was populated from.
     ProfileId profile_id;
   };
 
@@ skipping 99 matching lines @@
 
   // Pointed to by ResourceContext.
   mutable scoped_refptr<webkit_database::DatabaseTracker> database_tracker_;
   mutable scoped_refptr<ChromeAppCacheService> appcache_service_;
   mutable scoped_refptr<ChromeBlobStorageContext> blob_storage_context_;
   mutable scoped_refptr<fileapi::FileSystemContext> file_system_context_;
   mutable scoped_refptr<quota::QuotaManager> quota_manager_;
   mutable scoped_refptr<HostZoomMap> host_zoom_map_;
 
   // TODO(willchan): Remove from ResourceContext.
+  mutable scoped_refptr<ExtensionInfoMap> extension_info_map_;
   mutable scoped_refptr<HostContentSettingsMap> host_content_settings_map_;
-  mutable scoped_refptr<ExtensionInfoMap> extension_info_map_;
+  mutable DesktopNotificationService* notification_service_;

[willchan no longer on Chromium, 2011/06/28 09:08:40]

Isn't this a bug? DesktopNotificationService is owned and destroyed on the UI
thread when the ProfileManager is destroyed, which is before the IO thread is
stopped. Does this lead to shutdown use-after-free?

   mutable base::WeakPtr<prerender::PrerenderManager> prerender_manager_;
 
   mutable ResourceContext resource_context_;
 
   // These are only valid in between LazyInitialize() and their accessor being
   // called.
   mutable scoped_refptr<RequestContext> main_request_context_;
   mutable scoped_refptr<RequestContext> extensions_request_context_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileIOData);
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_