chrome/browser/notifications/desktop_notification_service.h - Issue 7125006: Get rid of Chrome notifications dependency, and instead go through ContentBrowserClient to show U...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/desktop_notification_service.h

Issue 7125006: Get rid of Chrome notifications dependency, and instead go through ContentBrowserClient to show U... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix browsertest Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/desktop_notification_handler_stub.cc ('k') | chrome/browser/notifications/desktop_notification_service.cc » ('j') | chrome/browser/profiles/profile_io_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/desktop_notification_service.h

===================================================================

--- chrome/browser/notifications/desktop_notification_service.h (revision 88079)

+++ chrome/browser/notifications/desktop_notification_service.h (working copy)

@@ -21,6 +21,7 @@

#include "content/common/notification_observer.h"

#include "content/common/notification_registrar.h"

#include "googleurl/src/gurl.h"

+#include "third_party/WebKit/Source/WebKit/chromium/public/WebNotificationPresenter.h"

#include "third_party/WebKit/Source/WebKit/chromium/public/WebTextDirection.h"

class Extension;

@@ -127,9 +128,9 @@

ContentSetting GetContentSetting(const GURL& origin);

// Checks to see if a given origin has permission to create desktop

- // notifications. Returns a constant from WebNotificationPresenter

- // class.

- int HasPermission(const GURL& origin);

+ // notifications.

+ WebKit::WebNotificationPresenter::Permission

+ HasPermission(const GURL& origin);

private:

void InitPrefs();