Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 7108037: Revert 88492 - In chromedriver, add /log url to get the contents of the chromedriver log (Closed)

Created:
9 years, 6 months ago by jamesr
Modified:
9 years, 6 months ago
Reviewers:
kkania
CC:
chromium-reviews, kkania, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 88492 - In chromedriver, add /log url to get the contents of the chromedriver log remotely. Also add a 'chrome.verbose' boolean startup option. Remove usage of VLOG(1) in chromedriver. We do not need as complicated logging as in Chrome. BUG=85241 TEST=none Review URL: http://codereview.chromium.org/7139001 TBR=kkania@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -234 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_json_requests.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/test/automation/automation_json_requests.cc View 2 chunks +28 lines, -23 lines 0 comments Download
M chrome/test/webdriver/automation.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/webdriver/chromedriver_tests.py View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/test/webdriver/commands/create_session.cc View 3 chunks +1 line, -16 lines 0 comments Download
M chrome/test/webdriver/commands/webdriver_command.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M chrome/test/webdriver/dispatch.h View 3 chunks +2 lines, -11 lines 0 comments Download
M chrome/test/webdriver/dispatch.cc View 6 chunks +15 lines, -56 lines 0 comments Download
M chrome/test/webdriver/keymap.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/server.cc View 6 chunks +32 lines, -13 lines 0 comments Download
M chrome/test/webdriver/session_manager.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/test/webdriver/utility_functions.h View 2 chunks +16 lines, -1 line 0 comments Download
M chrome/test/webdriver/utility_functions.cc View 1 chunk +63 lines, -0 lines 0 comments Download
D chrome/test/webdriver/webdriver_logging.h View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/test/webdriver/webdriver_logging.cc View 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
9 years, 6 months ago (2011-06-09 05:15:56 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698