Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: chrome/test/webdriver/dispatch.h

Issue 7108037: Revert 88492 - In chromedriver, add /log url to get the contents of the chromedriver log (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/commands/webdriver_command.cc ('k') | chrome/test/webdriver/dispatch.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/dispatch.h
===================================================================
--- chrome/test/webdriver/dispatch.h (revision 88495)
+++ chrome/test/webdriver/dispatch.h (working copy)
@@ -9,7 +9,6 @@
#include <vector>
#include "base/basictypes.h"
-#include "base/logging.h"
#include "chrome/test/webdriver/commands/response.h"
#include "third_party/mongoose/mongoose.h"
@@ -69,19 +68,15 @@
&path_segments,
&parameters,
&response)) {
- std::string post_data(request_info->post_data, request_info->post_data_len);
- LOG(INFO) << "Received command, url: " << request_info->uri
- << ", method: " << request_info->request_method
- << ", postd data: " << post_data;
internal::DispatchHelper(
new CommandType(path_segments, parameters),
method,
&response);
}
+
internal::SendResponse(connection,
request_info->request_method,
response);
- LOG(INFO) << "Sent command response, url: " << request_info->uri;
}
class Dispatcher {
@@ -105,12 +100,8 @@
// Registers a callback for the given pattern that will return a simple
// "HTTP/1.1 200 OK" message with "ok" in the body. Used for checking the
// status of the server.
- void AddHealthz(const std::string& pattern);
+ void AddStatus(const std::string& pattern);
- // Registers a callback for the given pattern that will return the current
- // WebDriver log contents.
- void AddLog(const std::string& pattern);
-
// Registers a callback that will always respond with a
// "HTTP/1.1 501 Not Implemented" message.
void SetNotImplemented(const std::string& pattern);
« no previous file with comments | « chrome/test/webdriver/commands/webdriver_command.cc ('k') | chrome/test/webdriver/dispatch.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698