In chromedriver, add /log url

In chromedriver, add /log url to get the contents of the chromedriver log
remotely. Also add a 'chrome.verbose' boolean startup option.
Remove usage of VLOG(1) in chromedriver. We do not need as complicated
logging as in Chrome.
BUG=85241
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88492

[Huyen, 2011-06-08 19:17:54]

http://codereview.chromium.org/7139001/diff/1/chrome/test/webdriver/dispatch.cc
File chrome/test/webdriver/dispatch.cc (right):

http://codereview.chromium.org/7139001/diff/1/chrome/test/webdriver/dispatch....
chrome/test/webdriver/dispatch.cc:66: const std::string& content) {
line up indentation of parameters.

http://codereview.chromium.org/7139001/diff/1/chrome/test/webdriver/dispatch....
chrome/test/webdriver/dispatch.cc:76: const struct mg_request_info*
request_info,
line up indentation of parameters.

http://codereview.chromium.org/7139001/diff/1/chrome/test/webdriver/dispatch....
chrome/test/webdriver/dispatch.cc:82: const struct mg_request_info*
request_info,
line up indentation of parameters.

http://codereview.chromium.org/7139001/diff/1/chrome/test/webdriver/dispatch....
chrome/test/webdriver/dispatch.cc:85: if (GetLogContents(&log)) {
Does GetLogContents() get all the previous logs? Is there a limit on the size of
the body of the HTTP respond?

http://codereview.chromium.org/7139001/diff/1/chrome/test/webdriver/dispatch....
chrome/test/webdriver/dispatch.cc:86: // KIWI Another \n before END?
Remove KIWI?

[Huyen, 2011-06-08 19:55:52]

http://codereview.chromium.org/7139001/diff/1/chrome/test/webdriver/dispatch.cc
File chrome/test/webdriver/dispatch.cc (right):

http://codereview.chromium.org/7139001/diff/1/chrome/test/webdriver/dispatch....
chrome/test/webdriver/dispatch.cc:25: #include
"chrome/test/webdriver/webdriver_logging.h"
Oh, did you forget to add webdriver_logging to this change?

[kkania, 2011-06-08 21:10:49]

http://codereview.chromium.org/7139001/diff/1/chrome/test/webdriver/dispatch.cc
File chrome/test/webdriver/dispatch.cc (right):

http://codereview.chromium.org/7139001/diff/1/chrome/test/webdriver/dispatch....
chrome/test/webdriver/dispatch.cc:66: const std::string& content) {
On 2011/06/08 19:17:54, Huyen wrote:
> line up indentation of parameters.

Done.

http://codereview.chromium.org/7139001/diff/1/chrome/test/webdriver/dispatch....
chrome/test/webdriver/dispatch.cc:76: const struct mg_request_info*
request_info,
On 2011/06/08 19:17:54, Huyen wrote:
> line up indentation of parameters.

Done.

http://codereview.chromium.org/7139001/diff/1/chrome/test/webdriver/dispatch....
chrome/test/webdriver/dispatch.cc:82: const struct mg_request_info*
request_info,
On 2011/06/08 19:17:54, Huyen wrote:
> line up indentation of parameters.

Done.

http://codereview.chromium.org/7139001/diff/1/chrome/test/webdriver/dispatch....
chrome/test/webdriver/dispatch.cc:85: if (GetLogContents(&log)) {
On 2011/06/08 19:17:54, Huyen wrote:
> Does GetLogContents() get all the previous logs? Is there a limit on the size
of
> the body of the HTTP respond?

If I send a message over ~32MB, it fails quickly. Not sure exactly why, probably
because of mongoose. Added cap at 16MB.

http://codereview.chromium.org/7139001/diff/1/chrome/test/webdriver/dispatch....
chrome/test/webdriver/dispatch.cc:86: // KIWI Another \n before END?
On 2011/06/08 19:17:54, Huyen wrote:
> Remove KIWI?

Done.

[Huyen, 2011-06-09 00:07:14]

LGTM. Will you also add the timeout change to this issue?

[commit-bot: I haz the power, 2011-06-09 01:55:37]

Commit queue patch verification failed

[commit-bot: I haz the power, 2011-06-09 05:06:29]

Change committed as 88492