Issue 7104076: Revert 88440 - Change Chrome OS version numbers to Platform versions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7104076: Revert 88440 - Change Chrome OS version numbers to Platform versions. (Closed)

Created:
9 years, 6 months ago by rkc

Modified:
9 years, 6 months ago

Reviewers:
rkc

CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+cc_chromium.org, davemoore+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 88440 - Change Chrome OS version numbers to Platform versions. Changed the version parsing for Chrome OS if a special function has been called to strip out the leading 0. and major version number. Additionally changed about chrome os, about chrome os -> more info, about:version and the login screen to reflect version numbers more in tune with a 'platform' than OS. BUG=chromium-os:15789 TEST=Viewed all the screens and took screenshots. Screen shots of all effected screens are attached to the cros bug Review URL: http://codereview.chromium.org/7108019 TBR=rkc@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88451

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -65 lines)			Patch
M	base/sys_info_chromeos.cc	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/browser_about_handler.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/background_view.cc	View	4 chunks	+4 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/version_loader.h	View	3 chunks	+1 line, -11 lines	0 comments	Download
M	chrome/browser/chromeos/version_loader.cc	View	4 chunks	+1 line, -23 lines	0 comments	Download
M	chrome/browser/resources/options/about_page.html	View	3 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/webui/options/about_page_handler.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages