Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: chrome/browser/chromeos/version_loader.h

Issue 7104076: Revert 88440 - Change Chrome OS version numbers to Platform versions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/background_view.cc ('k') | chrome/browser/chromeos/version_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/version_loader.h
===================================================================
--- chrome/browser/chromeos/version_loader.h (revision 88450)
+++ chrome/browser/chromeos/version_loader.h (working copy)
@@ -59,12 +59,6 @@
Handle GetFirmware(CancelableRequestConsumerBase* consumer,
GetFirmwareCallback* callback);
- // Parse the version information as a Chrome platfrom, not Chrome OS
- // TODO(rkc): Change this and everywhere it is used once we switch Chrome OS
- // over to xx.yyy.zz version numbers instead of 0.xx.yyy.zz
- // Refer to http://code.google.com/p/chromium-os/issues/detail?id=15789
- void EnablePlatformVersions(bool enable);
-
static const char kFullVersionPrefix[];
static const char kVersionPrefix[];
static const char kFirmwarePrefix[];
@@ -78,7 +72,7 @@
// and extract the version.
class Backend : public base::RefCountedThreadSafe<Backend> {
public:
- Backend() : parse_as_platform_(false) {}
+ Backend() {}
// Calls ParseVersion to get the version # and notifies request.
// This is invoked on the file thread.
@@ -90,13 +84,9 @@
// This is invoked on the file thread.
void GetFirmware(scoped_refptr<GetFirmwareRequest> request);
- void set_parse_as_platform(bool value) { parse_as_platform_ = value; }
-
private:
friend class base::RefCountedThreadSafe<Backend>;
- bool parse_as_platform_;
-
~Backend() {}
DISALLOW_COPY_AND_ASSIGN(Backend);
« no previous file with comments | « chrome/browser/chromeos/login/background_view.cc ('k') | chrome/browser/chromeos/version_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698