Change Chrome OS version numbers to Platform versions.

Change Chrome OS version numbers to Platform versions.
Changed the version parsing for Chrome OS if a special function has been called to strip out the leading 0. and major version number. Additionally changed about chrome os, about chrome os -> more info, about:version and the login screen to reflect version numbers more in tune with a 'platform' than OS.

BUG=chromium-os:15789
TEST=Viewed all the screens and took screenshots. Screen shots of all effected screens are attached to the cros bug

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88440

[DaveMoore, 2011-06-08 21:10:37]

http://codereview.chromium.org/7108019/diff/2001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/background_view.cc (right):

http://codereview.chromium.org/7108019/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/background_view.cc:416: // TODO(rkc): Fix this.
This needs to be in a resource file, but we have had
I'm not comfortable with an untranslated string in the source. Change to
something that's independent of translation.

http://codereview.chromium.org/7108019/diff/2001/chrome/browser/chromeos/vers...
File chrome/browser/chromeos/version_loader.h (right):

http://codereview.chromium.org/7108019/diff/2001/chrome/browser/chromeos/vers...
chrome/browser/chromeos/version_loader.h:93: void SetPlatformVersions(bool
value) { parse_as_platform_ = value; }
If this is a simple accessor with an inlined implementation it should be called
set_parse_as_platform(). If you want to keep the name then move the
implementation in the .cc file.

http://codereview.chromium.org/7108019/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/about_page.html (right):

http://codereview.chromium.org/7108019/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/about_page.html:40: </div>
Why has this moved sections?

[rkc, 2011-06-08 21:39:57]

http://codereview.chromium.org/7108019/diff/2001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/background_view.cc (right):

http://codereview.chromium.org/7108019/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/background_view.cc:416: // TODO(rkc): Fix this.
This needs to be in a resource file, but we have had
On 2011/06/08 21:10:37, davemoore wrote:
> I'm not comfortable with an untranslated string in the source. Change to
> something that's independent of translation.

Done.

http://codereview.chromium.org/7108019/diff/2001/chrome/browser/chromeos/vers...
File chrome/browser/chromeos/version_loader.h (right):

http://codereview.chromium.org/7108019/diff/2001/chrome/browser/chromeos/vers...
chrome/browser/chromeos/version_loader.h:93: void SetPlatformVersions(bool
value) { parse_as_platform_ = value; }
On 2011/06/08 21:10:37, davemoore wrote:
> If this is a simple accessor with an inlined implementation it should be
called
> set_parse_as_platform(). If you want to keep the name then move the
> implementation in the .cc file.

Done.

http://codereview.chromium.org/7108019/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/about_page.html (right):

http://codereview.chromium.org/7108019/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/about_page.html:40: </div>
On 2011/06/08 21:10:37, davemoore wrote:
> Why has this moved sections?
I re-ordered the sections to move the Chrome version to be the first one,
followed by cros version then the firmware version; I've reordered display above
also to keep it consistent.

[rkc, 2011-06-08 22:25:41]

Added Evan for the /base review.

[DaveMoore, 2011-06-08 22:39:22]

LGTM except for the base change (which looks pretty hacky to me)

[Evan Martin, 2011-06-08 22:40:03]

LGTM

man, that "(0 == i)" style is weird ;)

[Evan Martin, 2011-06-08 22:40:49]

On 2011/06/08 22:39:22, davemoore wrote:
> LGTM except for the base change (which looks pretty hacky to me)

Yeah that's a good point, actually.  Can't this just use base's "Version" class
to parse?

[rkc, 2011-06-08 23:30:47]

Discussed this with Evan, so since this is meant really for R12, checking this
in with a minimal code change base/sys_info_chromeos.cc. I'll cleanup the file
on trunk in my next CL.

On 2011/06/08 22:40:49, Evan Martin wrote:
> On 2011/06/08 22:39:22, davemoore wrote:
> > LGTM except for the base change (which looks pretty hacky to me)
> 
> Yeah that's a good point, actually.  Can't this just use base's "Version"
class
> to parse?