Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 7099003: Fixing race conidtion (Closed)

Created:
9 years, 6 months ago by braffert
Modified:
9 years, 6 months ago
CC:
chromium-reviews, ncarter (slow), idana, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

Fixing race condition in TwoClientLivePreferencesSyncTest.kAcceptLanguages sync integration test. BUG=85250 TEST=TwoClientLivePreferencesSyncTest.kAcceptLanguages Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88308

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/test/live_sync/two_client_live_preferences_sync_test.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
braffert
9 years, 6 months ago (2011-06-07 23:02:01 UTC) #1
braffert
9 years, 6 months ago (2011-06-07 23:27:37 UTC) #2
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 6 months ago (2011-06-08 00:30:32 UTC) #3
Raghu Simha
LGTM.
9 years, 6 months ago (2011-06-08 00:35:12 UTC) #4
braffert
9 years, 6 months ago (2011-06-08 00:43:01 UTC) #5
commit-bot: I haz the power
Try job failure for 7099003-3001 on win for step unit_tests: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=35777
9 years, 6 months ago (2011-06-08 01:27:57 UTC) #6
commit-bot: I haz the power
9 years, 6 months ago (2011-06-08 08:31:01 UTC) #7
Change committed as 88308

Powered by Google App Engine
This is Rietveld 408576698