Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: chrome/test/live_sync/two_client_live_preferences_sync_test.cc

Issue 7099003: Fixing race conidtion (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: rebase Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/values.h" 5 #include "base/values.h"
6 #include "chrome/browser/sync/profile_sync_service_harness.h" 6 #include "chrome/browser/sync/profile_sync_service_harness.h"
7 #include "chrome/browser/translate/translate_prefs.h" 7 #include "chrome/browser/translate/translate_prefs.h"
8 #include "chrome/common/pref_names.h" 8 #include "chrome/common/pref_names.h"
9 #include "chrome/test/live_sync/live_preferences_sync_test.h" 9 #include "chrome/test/live_sync/live_preferences_sync_test.h"
10 10
(...skipping 416 matching lines...) Expand 10 before | Expand all | Expand 10 after
427 kExtensionsUIDeveloperMode) { 427 kExtensionsUIDeveloperMode) {
428 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 428 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
429 ASSERT_TRUE(BooleanPrefMatches(prefs::kExtensionsUIDeveloperMode)); 429 ASSERT_TRUE(BooleanPrefMatches(prefs::kExtensionsUIDeveloperMode));
430 430
431 ChangeBooleanPref(0, prefs::kExtensionsUIDeveloperMode); 431 ChangeBooleanPref(0, prefs::kExtensionsUIDeveloperMode);
432 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 432 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
433 ASSERT_TRUE(BooleanPrefMatches(prefs::kExtensionsUIDeveloperMode)); 433 ASSERT_TRUE(BooleanPrefMatches(prefs::kExtensionsUIDeveloperMode));
434 } 434 }
435 435
436 // TCM ID - 7583816 436 // TCM ID - 7583816
437 // TODO(braffert): This test fails on linux. See http://crbug.com/85250. 437 IN_PROC_BROWSER_TEST_F(TwoClientLivePreferencesSyncTest, kAcceptLanguages) {
438 IN_PROC_BROWSER_TEST_F(TwoClientLivePreferencesSyncTest,
439 FAILS_kAcceptLanguages) {
440 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 438 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
439 DisableVerifier();
441 ASSERT_TRUE(StringPrefMatches(prefs::kAcceptLanguages)); 440 ASSERT_TRUE(StringPrefMatches(prefs::kAcceptLanguages));
442 441
443 AppendStringPref(0, prefs::kAcceptLanguages, ",ar"); 442 AppendStringPref(0, prefs::kAcceptLanguages, ",ar");
444 AppendStringPref(1, prefs::kAcceptLanguages, ",fr"); 443 AppendStringPref(1, prefs::kAcceptLanguages, ",fr");
445 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 444 ASSERT_TRUE(AwaitQuiescence());
446 // kAcceptLanguages is not synced on Mac. 445 // kAcceptLanguages is not synced on Mac.
447 #if !defined(OS_MACOSX) 446 #if !defined(OS_MACOSX)
448 ASSERT_TRUE(StringPrefMatches(prefs::kAcceptLanguages)); 447 ASSERT_TRUE(StringPrefMatches(prefs::kAcceptLanguages));
449 #else 448 #else
450 ASSERT_FALSE(StringPrefMatches(prefs::kAcceptLanguages)); 449 ASSERT_FALSE(StringPrefMatches(prefs::kAcceptLanguages));
451 #endif // OS_MACOSX 450 #endif // OS_MACOSX
452 451
453 ChangeStringPref(0, prefs::kAcceptLanguages, "en-US"); 452 ChangeStringPref(0, prefs::kAcceptLanguages, "en-US");
454 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 453 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
455 #if !defined(OS_MACOSX) 454 #if !defined(OS_MACOSX)
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 515
517 ChangeBooleanPref(0, prefs::kEnableScreenLock); 516 ChangeBooleanPref(0, prefs::kEnableScreenLock);
518 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 517 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
519 ASSERT_TRUE(BooleanPrefMatches(prefs::kEnableScreenLock)); 518 ASSERT_TRUE(BooleanPrefMatches(prefs::kEnableScreenLock));
520 519
521 ChangeBooleanPref(1, prefs::kEnableScreenLock); 520 ChangeBooleanPref(1, prefs::kEnableScreenLock);
522 ASSERT_TRUE(GetClient(1)->AwaitMutualSyncCycleCompletion(GetClient(0))); 521 ASSERT_TRUE(GetClient(1)->AwaitMutualSyncCycleCompletion(GetClient(0)));
523 ASSERT_TRUE(BooleanPrefMatches(prefs::kEnableScreenLock)); 522 ASSERT_TRUE(BooleanPrefMatches(prefs::kEnableScreenLock));
524 } 523 }
525 #endif // OS_CHROMEOS 524 #endif // OS_CHROMEOS
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698