Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3125)

Unified Diff: chrome/test/live_sync/two_client_live_preferences_sync_test.cc

Issue 7099003: Fixing race conidtion (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: rebase Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/live_sync/two_client_live_preferences_sync_test.cc
diff --git a/chrome/test/live_sync/two_client_live_preferences_sync_test.cc b/chrome/test/live_sync/two_client_live_preferences_sync_test.cc
index 306bd91b6c953080c68b04cd1988aa2d01d54a77..86be27402758bac0efe6a01a5561d4bbc754b270 100644
--- a/chrome/test/live_sync/two_client_live_preferences_sync_test.cc
+++ b/chrome/test/live_sync/two_client_live_preferences_sync_test.cc
@@ -434,15 +434,14 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePreferencesSyncTest,
}
// TCM ID - 7583816
-// TODO(braffert): This test fails on linux. See http://crbug.com/85250.
-IN_PROC_BROWSER_TEST_F(TwoClientLivePreferencesSyncTest,
- FAILS_kAcceptLanguages) {
+IN_PROC_BROWSER_TEST_F(TwoClientLivePreferencesSyncTest, kAcceptLanguages) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
+ DisableVerifier();
ASSERT_TRUE(StringPrefMatches(prefs::kAcceptLanguages));
AppendStringPref(0, prefs::kAcceptLanguages, ",ar");
AppendStringPref(1, prefs::kAcceptLanguages, ",fr");
- ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
+ ASSERT_TRUE(AwaitQuiescence());
// kAcceptLanguages is not synced on Mac.
#if !defined(OS_MACOSX)
ASSERT_TRUE(StringPrefMatches(prefs::kAcceptLanguages));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698