Issue 7071035: Revert 86990 - Fix http://codereview.chromium.org/6869009 to ignore an existing object exactly on...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7071035: Revert 86990 - Fix http://codereview.chromium.org/6869009 to ignore an existing object exactly on... (Closed)

Created:
9 years, 7 months ago by msw

Modified:
9 years, 7 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Alexander Potapenko, brettw-cc_chromium.org, Timur Iskhodzhanov, cbentzel+watch_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 86990 - Fix http://codereview.chromium.org/6869009 to ignore an existing object exactly once and land the CL again: Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to mark heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions. BUG=79322 TBR=jar Review URL: http://codereview.chromium.org/6976044 TBR=glider@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86993

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -31 lines)			Patch
M	base/allocator/allocator.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/debug/leak_annotations.h	View	2 chunks	+1 line, -13 lines	0 comments	Download
M	base/metrics/histogram.cc	View	5 chunks	+0 lines, -9 lines	0 comments	Download
M	net/disk_cache/stats.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/stats_histogram.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/stats_histogram.cc	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	tools/heapcheck/suppressions.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages