Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 6976044: Fix http://codereview.chromium.org/6869009 to ignore an existing object exactly once and land the... (Closed)

Created:
9 years, 7 months ago by Alexander Potapenko
Modified:
9 years, 6 months ago
Reviewers:
CC:
chromium-reviews, Alexander Potapenko, brettw-cc_chromium.org, Timur Iskhodzhanov, cbentzel+watch_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Fix http://codereview.chromium.org/6869009 to ignore an existing object exactly once and land the CL again: Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to mark heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions. BUG=79322 TBR=jar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86990

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M base/allocator/allocator.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M base/debug/leak_annotations.h View 2 chunks +13 lines, -1 line 0 comments Download
M base/metrics/histogram.cc View 5 chunks +9 lines, -0 lines 0 comments Download
M net/disk_cache/stats.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/stats_histogram.h View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/stats_histogram.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698