Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: base/metrics/histogram.cc

Issue 7071035: Revert 86990 - Fix http://codereview.chromium.org/6869009 to ignore an existing object exactly on... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug/leak_annotations.h ('k') | net/disk_cache/stats.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram.cc
===================================================================
--- base/metrics/histogram.cc (revision 86992)
+++ base/metrics/histogram.cc (working copy)
@@ -14,7 +14,6 @@
#include <algorithm>
#include <string>
-#include "base/debug/leak_annotations.h"
#include "base/logging.h"
#include "base/pickle.h"
#include "base/stringprintf.h"
@@ -98,8 +97,6 @@
tentative_histogram->SetFlags(flags);
histogram =
StatisticsRecorder::RegisterOrDeleteDuplicate(tentative_histogram);
- if (histogram == tentative_histogram)
- ANNOTATE_LEAKING_OBJECT_PTR(histogram); // see crbug.com/79322
}
DCHECK_EQ(HISTOGRAM, histogram->histogram_type());
@@ -794,8 +791,6 @@
tentative_histogram->SetFlags(flags);
histogram =
StatisticsRecorder::RegisterOrDeleteDuplicate(tentative_histogram);
- if (histogram == tentative_histogram)
- ANNOTATE_LEAKING_OBJECT_PTR(histogram); // see crbug.com/79322
}
DCHECK_EQ(LINEAR_HISTOGRAM, histogram->histogram_type());
@@ -887,8 +882,6 @@
tentative_histogram->SetFlags(flags);
histogram =
StatisticsRecorder::RegisterOrDeleteDuplicate(tentative_histogram);
- if (histogram == tentative_histogram)
- ANNOTATE_LEAKING_OBJECT_PTR(histogram); // see crbug.com/79322
}
DCHECK_EQ(BOOLEAN_HISTOGRAM, histogram->histogram_type());
@@ -936,8 +929,6 @@
tentative_histogram->SetFlags(flags);
histogram =
StatisticsRecorder::RegisterOrDeleteDuplicate(tentative_histogram);
- if (histogram == tentative_histogram)
- ANNOTATE_LEAKING_OBJECT_PTR(histogram); // see crbug.com/79322
}
DCHECK_EQ(histogram->histogram_type(), CUSTOM_HISTOGRAM);
« no previous file with comments | « base/debug/leak_annotations.h ('k') | net/disk_cache/stats.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698