chrome/browser/ui/gtk/browser_toolbar_gtk.cc - Issue 7068007: Revise about: and chrome: url handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/browser_toolbar_gtk.cc

Issue 7068007: Revise about: and chrome: url handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update special_tabs.py from Nirnimesh's codereview.chromium.org/6995057/. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/browser_toolbar_gtk.cc

diff --git a/chrome/browser/ui/gtk/browser_toolbar_gtk.cc b/chrome/browser/ui/gtk/browser_toolbar_gtk.cc

index a401f54715a49f0b8a6b8da14e76e3b051befc4f..06238dd033803bfd6c305cc93c746fd749b2c5ee 100644

--- a/chrome/browser/ui/gtk/browser_toolbar_gtk.cc

+++ b/chrome/browser/ui/gtk/browser_toolbar_gtk.cc

@@ -35,7 +35,6 @@

#include "chrome/browser/ui/gtk/tabs/tab_strip_gtk.h"

#include "chrome/browser/ui/gtk/view_id_util.h"

#include "chrome/browser/ui/toolbar/encoding_menu_controller.h"

-#include "chrome/browser/ui/webui/web_ui_util.h"

#include "chrome/browser/upgrade_detector.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

@@ -607,8 +606,8 @@ void BrowserToolbarGtk::OnDragDataReceived(GtkWidget* widget,

if (!url.is_valid())

return;

- bool url_is_newtab =

- web_ui_util::ChromeURLHostEquals(url, chrome::kChromeUINewTabHost);

+ bool url_is_newtab = url.SchemeIs(chrome::kChromeUIScheme) &&

+ url.host() == chrome::kChromeUINewTabHost;

home_page_is_new_tab_page_.SetValue(url_is_newtab);

if (!url_is_newtab)

home_page_.SetValue(url.spec());

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/webui/BidiCheckerWebUITest.cc » ('j') | no next file with comments »