Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: chrome/browser/ui/gtk/browser_toolbar_gtk.cc

Issue 7068007: Revise about: and chrome: url handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update special_tabs.py from Nirnimesh's codereview.chromium.org/6995057/. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/webui/BidiCheckerWebUITest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/browser_toolbar_gtk.h" 5 #include "chrome/browser/ui/gtk/browser_toolbar_gtk.h"
6 6
7 #include <X11/XF86keysym.h> 7 #include <X11/XF86keysym.h>
8 #include <gdk/gdkkeysyms.h> 8 #include <gdk/gdkkeysyms.h>
9 #include <gtk/gtk.h> 9 #include <gtk/gtk.h>
10 10
(...skipping 17 matching lines...) Expand all
28 #include "chrome/browser/ui/gtk/custom_button.h" 28 #include "chrome/browser/ui/gtk/custom_button.h"
29 #include "chrome/browser/ui/gtk/gtk_chrome_button.h" 29 #include "chrome/browser/ui/gtk/gtk_chrome_button.h"
30 #include "chrome/browser/ui/gtk/gtk_theme_service.h" 30 #include "chrome/browser/ui/gtk/gtk_theme_service.h"
31 #include "chrome/browser/ui/gtk/gtk_util.h" 31 #include "chrome/browser/ui/gtk/gtk_util.h"
32 #include "chrome/browser/ui/gtk/location_bar_view_gtk.h" 32 #include "chrome/browser/ui/gtk/location_bar_view_gtk.h"
33 #include "chrome/browser/ui/gtk/reload_button_gtk.h" 33 #include "chrome/browser/ui/gtk/reload_button_gtk.h"
34 #include "chrome/browser/ui/gtk/rounded_window.h" 34 #include "chrome/browser/ui/gtk/rounded_window.h"
35 #include "chrome/browser/ui/gtk/tabs/tab_strip_gtk.h" 35 #include "chrome/browser/ui/gtk/tabs/tab_strip_gtk.h"
36 #include "chrome/browser/ui/gtk/view_id_util.h" 36 #include "chrome/browser/ui/gtk/view_id_util.h"
37 #include "chrome/browser/ui/toolbar/encoding_menu_controller.h" 37 #include "chrome/browser/ui/toolbar/encoding_menu_controller.h"
38 #include "chrome/browser/ui/webui/web_ui_util.h"
39 #include "chrome/browser/upgrade_detector.h" 38 #include "chrome/browser/upgrade_detector.h"
40 #include "chrome/common/pref_names.h" 39 #include "chrome/common/pref_names.h"
41 #include "chrome/common/url_constants.h" 40 #include "chrome/common/url_constants.h"
42 #include "content/browser/tab_contents/tab_contents.h" 41 #include "content/browser/tab_contents/tab_contents.h"
43 #include "content/browser/user_metrics.h" 42 #include "content/browser/user_metrics.h"
44 #include "content/common/notification_details.h" 43 #include "content/common/notification_details.h"
45 #include "content/common/notification_service.h" 44 #include "content/common/notification_service.h"
46 #include "content/common/notification_type.h" 45 #include "content/common/notification_type.h"
47 #include "grit/chromium_strings.h" 46 #include "grit/chromium_strings.h"
48 #include "grit/generated_resources.h" 47 #include "grit/generated_resources.h"
(...skipping 551 matching lines...) Expand 10 before | Expand all | Expand 10 after
600 GtkSelectionData* data, guint info, guint time) { 599 GtkSelectionData* data, guint info, guint time) {
601 if (info != ui::TEXT_PLAIN) { 600 if (info != ui::TEXT_PLAIN) {
602 NOTIMPLEMENTED() << "Only support plain text drops for now, sorry!"; 601 NOTIMPLEMENTED() << "Only support plain text drops for now, sorry!";
603 return; 602 return;
604 } 603 }
605 604
606 GURL url(reinterpret_cast<char*>(data->data)); 605 GURL url(reinterpret_cast<char*>(data->data));
607 if (!url.is_valid()) 606 if (!url.is_valid())
608 return; 607 return;
609 608
610 bool url_is_newtab = 609 bool url_is_newtab = url.SchemeIs(chrome::kChromeUIScheme) &&
611 web_ui_util::ChromeURLHostEquals(url, chrome::kChromeUINewTabHost); 610 url.host() == chrome::kChromeUINewTabHost;
612 home_page_is_new_tab_page_.SetValue(url_is_newtab); 611 home_page_is_new_tab_page_.SetValue(url_is_newtab);
613 if (!url_is_newtab) 612 if (!url_is_newtab)
614 home_page_.SetValue(url.spec()); 613 home_page_.SetValue(url.spec());
615 } 614 }
616 615
617 void BrowserToolbarGtk::NotifyPrefChanged(const std::string* pref) { 616 void BrowserToolbarGtk::NotifyPrefChanged(const std::string* pref) {
618 if (!pref || *pref == prefs::kShowHomeButton) { 617 if (!pref || *pref == prefs::kShowHomeButton) {
619 if (show_home_button_.GetValue() && !ShouldOnlyShowLocation()) { 618 if (show_home_button_.GetValue() && !ShouldOnlyShowLocation()) {
620 gtk_widget_show(home_->widget()); 619 gtk_widget_show(home_->widget());
621 } else { 620 } else {
(...skipping 29 matching lines...) Expand all
651 int x_offset = base::i18n::IsRTL() ? 0 : 650 int x_offset = base::i18n::IsRTL() ? 0 :
652 sender->allocation.width - badge->width(); 651 sender->allocation.width - badge->width();
653 int y_offset = 0; 652 int y_offset = 0;
654 canvas.DrawBitmapInt( 653 canvas.DrawBitmapInt(
655 *badge, 654 *badge,
656 sender->allocation.x + x_offset, 655 sender->allocation.x + x_offset,
657 sender->allocation.y + y_offset); 656 sender->allocation.y + y_offset);
658 657
659 return FALSE; 658 return FALSE;
660 } 659 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/webui/BidiCheckerWebUITest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698