chrome/browser/ui/browser.cc - Issue 7068007: Revise about: and chrome: url handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 7068007: Revise about: and chrome: url handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update special_tabs.py from Nirnimesh's codereview.chromium.org/6995057/. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index a86afce9005afc41e24958a2d856d5ec2cdbbe3f..ceb1f9d2fc6c899610a8ba4545410f8c24b9d3ff 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -96,7 +96,6 @@

#include "chrome/browser/ui/webui/active_downloads_ui.h"

#include "chrome/browser/ui/webui/bug_report_ui.h"

#include "chrome/browser/ui/webui/options/content_settings_handler.h"

-#include "chrome/browser/ui/webui/web_ui_util.h"

#include "chrome/browser/ui/window_sizer.h"

#include "chrome/browser/upgrade_detector.h"

#include "chrome/browser/web_applications/web_app.h"

@@ -1612,7 +1611,8 @@ void Browser::ToggleFullscreenMode() {

void Browser::Search() {

// If the NTP is showing, close it.

const GURL& url = GetSelectedTabContents()->GetURL();

- if (web_ui_util::ChromeURLHostEquals(url, chrome::kChromeUINewTabHost)) {

+ if (url.SchemeIs(chrome::kChromeUIScheme) &&

+ url.host() == chrome::kChromeUINewTabHost) {

CloseTab();

return;

}

« no previous file with comments | « chrome/browser/tabs/tab_strip_model.cc ('k') | chrome/browser/ui/gtk/browser_toolbar_gtk.cc » ('j') | no next file with comments »