Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7067036: Options: Remove the hidden class, since we override the hidden attribute to set (Closed)

Created:
9 years, 7 months ago by James Hawkins
Modified:
9 years, 6 months ago
Reviewers:
csilv, whywhat
CC:
chromium-reviews, GeorgeY, tfarina, arv (Not doing code reviews), Ilya Sherman, dhollowa
Visibility:
Public.

Description

Options: Remove the hidden class, since we override the hidden attribute to set display:none already. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86514

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -102 lines) Patch
M chrome/browser/resources/options/about_page.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/about_page.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/advanced_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/alert_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/autofill_edit_address_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/autofill_edit_creditcard_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/autofill_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/certificate_backup_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/certificate_edit_ca_trust_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/certificate_import_error_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/certificate_manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/certificate_restore_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/accounts_options.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/chromeos/accounts_options.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/change_picture_options.html View 1 chunk +9 lines, -5 lines 1 comment Download
M chrome/browser/resources/options/chromeos/internet_detail.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/internet_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/language_chewing_options.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/chromeos/language_customize_modifier_keys_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/language_hangul_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/language_mozc_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/language_pinyin_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/proxy.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/system_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/clear_browser_data_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/content_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/content_settings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/content_settings_exceptions_area.html View 6 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/resources/options/content_settings_exceptions_area.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/cookies_list.js View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/cookies_view.html View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/font_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/import_data_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/instant_confirm_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/language_add_language_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/language_options.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/language_options.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/options_page.css View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/options/options_page.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/password_manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/password_manager_list.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/personal_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/personal_options.js View 4 chunks +5 lines, -13 lines 0 comments Download
M chrome/browser/resources/options/search_engine_manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/search_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/search_page.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/sync_setup_overlay.html View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/sync_setup_overlay.js View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
James Hawkins
9 years, 7 months ago (2011-05-24 20:35:53 UTC) #1
csilv
LGTM!
9 years, 7 months ago (2011-05-24 20:57:42 UTC) #2
whywhat
9 years, 6 months ago (2011-06-22 13:16:48 UTC) #3 
http://codereview.chromium.org/7067036/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/chromeos/change_picture_options.html
(right):

http://codereview.chromium.org/7067036/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/chromeos/change_picture_options.html:8: </div>
I believe this introduced
http://code.google.com/p/chromium-os/issues/detail?id=16313

Powered by Google App Engine
This is Rietveld 408576698