chrome/browser/resources/options/password_manager_list.js - Issue 7067036: Options: Remove the hidden class, since we override the hidden attribute to set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/password_manager_list.js

Issue 7067036: Options: Remove the hidden class, since we override the hidden attribute to set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/chromeos/change_picture_options.html ('K') | « chrome/browser/resources/options/password_manager.html ('k') | chrome/browser/resources/options/personal_options.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/password_manager_list.js

diff --git a/chrome/browser/resources/options/password_manager_list.js b/chrome/browser/resources/options/password_manager_list.js

index 4135bd3591bc363b70747b1db6198a2461a72933..e68a513c8c63a824fd823380f0857540c3aa0233 100644

--- a/chrome/browser/resources/options/password_manager_list.js

+++ b/chrome/browser/resources/options/password_manager_list.js

@@ -60,7 +60,7 @@ cr.define('options.passwordManager', function() {

// The show/hide button.

if (showPasswords) {

var button = this.ownerDocument.createElement('button');

- button.classList.add('hidden');

+ button.hidden = true;

button.classList.add('password-button');

button.textContent = localStrings.getString('passwordShowButton');

button.addEventListener('click', this.onClick_, true);

@@ -81,10 +81,10 @@ cr.define('options.passwordManager', function() {

return;

if (this.selected) {

input.classList.remove('inactive-password');

- button.classList.remove('hidden');

+ button.hidden = false;

} else {

input.classList.add('inactive-password');

- button.classList.add('hidden');

+ button.hidden = true;

}