chrome/browser/resources/options/cookies_list.js - Issue 7067036: Options: Remove the hidden class, since we override the hidden attribute to set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/cookies_list.js

Issue 7067036: Options: Remove the hidden class, since we override the hidden attribute to set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/chromeos/change_picture_options.html ('K') | « chrome/browser/resources/options/content_settings_exceptions_area.js ('k') | chrome/browser/resources/options/cookies_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/cookies_list.js

diff --git a/chrome/browser/resources/options/cookies_list.js b/chrome/browser/resources/options/cookies_list.js

index ab89c308f374181819cffcfb36e2f8b10df56e41..7567ed9b496f942b54b5c18e19699672d1f38280 100644

--- a/chrome/browser/resources/options/cookies_list.js

+++ b/chrome/browser/resources/options/cookies_list.js

@@ -101,7 +101,8 @@ cr.define('options', function() {

this.itemsChild = this.ownerDocument.createElement('div');

this.itemsChild.className = 'cookie-items';

this.infoChild = this.ownerDocument.createElement('div');

- this.infoChild.className = 'cookie-details hidden';

+ this.infoChild.className = 'cookie-details';

+ this.infoChild.hidden = true;

var remove = this.ownerDocument.createElement('button');

remove.textContent = localStrings.getString('remove_cookie');

remove.onclick = this.removeCookie_.bind(this);

@@ -237,7 +238,7 @@ cr.define('options', function() {

updateItems_: function() {

this.disableAnimation_();

this.itemsChild.textContent = '';

- this.infoChild.classList.add('hidden');

+ this.infoChild.hidden = true;

this.selectedIndex_ = -1;

this.itemList_ = [];

if (this.origin)

@@ -294,7 +295,7 @@ cr.define('options', function() {

if (itemIndex < 0 || itemIndex >= this.itemList_.length) {

this.selectedIndex_ = -1;

this.disableAnimation_();

- this.infoChild.classList.add('hidden');

+ this.infoChild.hidden = true;

this.enableAnimation_();

return;

}

@@ -304,7 +305,7 @@ cr.define('options', function() {

this.disableAnimation_();

this.itemList_[itemIndex].node.setDetailText(this.infoChild,

this.list.infoNodes);

- this.infoChild.classList.remove('hidden');

+ this.infoChild.hidden = false;

this.enableAnimation_();

// If we're near the bottom of the list this may cause the list item to go

// beyond the end of the visible area. Fix it after the animation is done.