dom-ui sync: Eliminate jank when customizing sync settings.

dom-ui sync: Eliminate jank when customizing sync settings. Also, tweak chrome.send message identifiers to that they are less likely to conflict.

BUG=80477
TEST=Invoke 'Customize' sync setings, dialog should fade-in smoothly.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86365

[csilv, 2011-05-21 21:12:44]

+jhawkins for review.

(still awaiting trybots, but will get those all to go green before any commit.)

[James Hawkins, 2011-05-22 00:18:04]

What happens in the case where the user navigates to
chrome://settings/syncSetup?

http://codereview.chromium.org/7057038/diff/11004/chrome/browser/ui/gtk/bookm...
File chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc (right):

http://codereview.chromium.org/7057038/diff/11004/chrome/browser/ui/gtk/bookm...
chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc:1024:
sync_service_->ShowErrorUI(NULL);
How does this work if the options page is already open and the user clicks on
the sync error button in the bookmark bar?

[csilv, 2011-05-22 19:48:12]

The same thing that happens in current build... it doesn't work.  :-(  Not sure
if there is already a bug about this?  I'll investigate and incorporate a fix in
this CL.

On 2011/05/22 00:18:04, James Hawkins wrote:
> What happens in the case where the user navigates to
> chrome://settings/syncSetup?
> 
>
http://codereview.chromium.org/7057038/diff/11004/chrome/browser/ui/gtk/bookm...
> File chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc (right):
> 
>
http://codereview.chromium.org/7057038/diff/11004/chrome/browser/ui/gtk/bookm...
> chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc:1024:
> sync_service_->ShowErrorUI(NULL);
> How does this work if the options page is already open and the user clicks on
> the sync error button in the bookmark bar?

[csilv, 2011-05-22 19:48:32]

http://codereview.chromium.org/7057038/diff/11004/chrome/browser/ui/gtk/bookm...
File chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc (right):

http://codereview.chromium.org/7057038/diff/11004/chrome/browser/ui/gtk/bookm...
chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc:1024:
sync_service_->ShowErrorUI(NULL);
The behavior should be exactly the same as before.  I'm not sure if the Mac
client ever shows this button on the bookmark bar, I'll see if I can exercise
this to confirm.

On 2011/05/22 00:18:04, James Hawkins wrote:
> How does this work if the options page is already open and the user clicks on
> the sync error button in the bookmark bar?

[James Hawkins, 2011-05-23 22:00:37]

LGTM

http://codereview.chromium.org/7057038/diff/19015/chrome/browser/resources/op...
File chrome/browser/resources/options/sync_setup_overlay.js (right):

http://codereview.chromium.org/7057038/diff/19015/chrome/browser/resources/op...
chrome/browser/resources/options/sync_setup_overlay.js:272: * @private
nit: @param

[csilv, 2011-05-23 23:29:03]

http://codereview.chromium.org/7057038/diff/19015/chrome/browser/resources/op...
File chrome/browser/resources/options/sync_setup_overlay.js (right):

http://codereview.chromium.org/7057038/diff/19015/chrome/browser/resources/op...
chrome/browser/resources/options/sync_setup_overlay.js:272: * @private
On 2011/05/23 22:00:37, James Hawkins wrote:
> nit: @param

Done.